Controller action ordering about rails-style-guide HOT 11 OPEN

Feel free to intermingle them with additional non-resourceful actions deliberately.

This feels like it encourages non-resourceful actions, rather than just permitting them. How about:

Use a consistent order for the resourceful actions in your controller. Non-resourceful actions can be interspersed where needed.

from rails-style-guide.

I'd love to see a confirmation that this order is followed by real-world Rails apps.

from rails-style-guide.

I don't think the default order is logical - How about "Use a consistent order of resourceful actions in your controller"

from rails-style-guide.

A cop can then be written to allow the developer to configure their preferred order (without any default).

The cop has been already written.

I believe the issue remains open due to this comment.

from rails-style-guide.

Just for the sake of discussion, another possible way of ordering could be to follow CRUD, e.g.:

new create index show edit update destroy

from rails-style-guide.

Also, as this Stack Overflow post says, some people may prefer to group the new/create and edit/update pairs together.

from rails-style-guide.

I honestly like the CRUD order better, but consistency is my no. 1 priority. (I really just want to see a rubocop, but they refered me to this guide).

from rails-style-guide.

The default order of controller actions in rails scaffolds are:

I agree with the default order if this rule is needed. I think it's better to follow the scaffold order. This is the official starting point of Rails.

from rails-style-guide.

What do you think of a soft wording for the guideline? e.g.

Use the default order of resourceful actions in your controller. Feel free to intermingle them with additional non-resourceful actions deliberately.

from rails-style-guide.

The default order of controller actions in rails scaffolds are:
index show new edit create update destroy

Yes, and the order is grouped by HTTP method.

However, the order displayed at http://localhost:3000/rails/info/routes is different:
index create new edit show update destroy

from rails-style-guide.

Since it's proving difficult to reach an agreed ordering, perhaps the guideline should just be to use a consistent ordering.

A cop can then be written to allow the developer to configure their preferred order (without any default).

from rails-style-guide.