Git Product home page Git Product logo

Comments (3)

RubenVerborgh avatar RubenVerborgh commented on June 15, 2024

Yes—but the test above is benchmarking a situation that should never happen.
It tests the pattern:

  • 50,000,000 elements in
  • 50,000,000 elements out

However, actual patterns will look like this:

  • 2 elements in
  • 1 element out
  • 1 element in
  • 2 elements out
  • 4 elements in
  • 1 element out

So we'd need evidence that the performance gains translate to frequent additions/deletions.

Separately, it's good for V8 to have some warmup runs before measuring.

from asynciterator.

RubenVerborgh avatar RubenVerborgh commented on June 15, 2024

I created a quick example:

// 100 iterators, with 1,000,000 push/read sequences of 0–4 items

console.time('LinkedList');
for (let a = 0; a < 100; a++) {
  const list = new LinkedList();
  for (let i = 0; i < 1_000_000; i++) {
    for (let j = randInt(0, 4); j > 0; j--)
      list.push(i);
    for (let j = randInt(0, 4); j > 0; j--)
      list.shift();
  }
}
console.timeEnd('LinkedList');

console.time('LinkedListNext');
for (let a = 0; a < 100; a++) {
  const list = new LinkedListNext();
  for (let i = 0; i < 1_000_000; i++) {
    for (let j = randInt(0, 4); j > 0; j--)
      list.push(i);
    for (let j = randInt(0, 4); j > 0; j--)
      list.shift();
  }
}
console.timeEnd('LinkedListNext');

function randInt(min: number, max: number) {
  return Math.floor(Math.random() * (max - min + 1)) + min;
}

which yields for me

LinkedList: 6.865s
LinkedListNext: 6.584s

And this includes the fact that LinkedListNext keeps a lot of items in memory.

from asynciterator.

RubenVerborgh avatar RubenVerborgh commented on June 15, 2024

I'll close this for now until new evidence emerges.

from asynciterator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.