HTML5 required attribute about angular-select2 HOT 2 OPEN

can I make a PR with this improvement

Certainly! Always welcome!

from angular-select2.

Well, I discovered that the select2 directive does transfer the attributes to the internal input hidden field, even the required attribute.
The problem is that the HTML5 specification does not validate hidden fields.

I got what I wanted with these lines of code:

if(attrs.required){
   element[0].style = "display:visible; position:absolute; clip:rect(0,0,0,0);";
   element[0].type = "text";
}

But I don't know about HTML5 semantics, acessibility and I dont think it was an elegant solution. Because of that, I don't think that this may be useful for this project and maybe I will do this only on my company's project, because there is no rule there. 😁

I will study more about this difficulty and about this project's code.

Thanks for your time.

from angular-select2.