Git Product home page Git Product logo

Comments (3)

rtyley avatar rtyley commented on June 12, 2024

Please make it preserve cr/lf at least on unaffected files. After running bgf repo cleaner all files where converted from lf to crlf.

This is definitely not how the BFG is supposed to behave, and I suspect that the BFG wasn't responsible for these changes.

If a file isn't specified for a change, the BFG will leave it exactly how it is, verifiable to the fidelity of a SHA-1 hash. If a file is specified for a change, the BFG will use this specific library for processing the text, which specifically preserves line-breaks:

https://github.com/rtyley/line-break-preserving-line-splitting

It's possible there is a bug somewhere, but it's a bit unlikely. If you could provide a small sample repo containing 'LF' line endings, along with a BFG command that exhibits the behaviour you specify when run against the repo, I can take a further look?

from bfg-repo-cleaner.

sulakm avatar sulakm commented on June 12, 2024

Sorry, I can't provide a sample. Command was bfg --replace-text passwords.txt .git in the root directory where .git was.

from bfg-repo-cleaner.

rtyley avatar rtyley commented on June 12, 2024

I've added a couple of specific tests for newline-preservation with #486, but they pass successfully and I haven't been able to reproduce the issue you saw. I think it's quite likely that the newline changes you saw were produced by some other effect than the action of the BFG. If you'd like to produce a small sample repo and a mock passwords.txt that reproduces the issue, I could take another look, but otherwise I'll be closing this issue for now.

from bfg-repo-cleaner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.