IDNA encoding/decoding issue about dnspython HOT 5 CLOSED

On Nov 29, 2013, at 6:33, bastiak [email protected] wrote:

--> 348 s = u'.'.join([encodings.idna.ToUnicode(_escapify(x)) for x in l])

I think we need to call something like _escapify after calling encodings.idna.ToUnicode(), but I'm not quite sure what that something is. Clearly "." (and perhaps unicode equivalents to ".") need to be escaped, and escaping space seems sensible, but on the other hand just calling _escapify() is bad because it ends up escaping unicode code points > 127, which seems bad.

I don't know enough about Unicode to know if other whitespace-like things need escaping, if there are any.

I will ponder this further, but anyone who knows Unicode well is encouraged to help :)

/Bob

from dnspython.

Sorry for late answer, I was busy.

In my opinion, in encodings.idna.ToUnicode(value) value should be "de-escapified" string.
Also in encodings.idna.ToASCII(value2) value2 should be pure unicode without escaping.
Python lib handles special cases and will throw an error if it happens.

I'm not sure, but in my opinion the dns.name.to_unicode() method should provide only human readable form of the domain name without any escaping.

from dnspython.

Hi,
do you accept my proposal?

dns.name.from_unicode() should remove any escaping and make a pure unicode string per label, then encode labels with encodings.idna.ToASCII() (labels are stored in punycoded notation without escaping)

dns.name.Name.to_unicode() should convert labels with encodings.idna.ToUnicode() and then escape characters per label

dns.name.Name.to_text() should only escape some required characters per label

I haven't inspected to_wire() and from_wire() yet.

I would like to make a patch.
Bastiak

from dnspython.

On Mar 28, 2014, at 6:44, bastiak [email protected] wrote:

Hi,
do you accept my proposal?

dns.name.from_unicode() should remove any escaping and make a pure unicode string per label, then encode labels with encodings.idna.ToASCII() (labels are stored in punycoded notation without escaping)

Yes
dns.name.Name.to_unicode() should convert labels with encodings.idna.ToUnicode() and then escape characters per label

This is probably the right thing, but the escaping is different. Probably only the "special characters" in _escaped should be escaped, and perhaps values < 0x20, but values >= 0x80 need to be left alone.
dns.name.Name.to_text() should only escape some required characters per label

dns.name.Name.to_text() should not be changed at all.

I haven't inspected to_wire() and from_wire() yet.

These should not be changed either.

/Bob

from dnspython.

but spaces are not allowed in domain names ...

from dnspython.