Generic `RowDataType` usability (introduced in #418) about rsuite-table HOT 4 CLOSED

I think I'm running into the same issue, just with a different error (the commonality being never).

From what I can tell, this is caused here:

The constraint for Row is RowDataType. RowDataType's default type argument is never:

So this means, the constraint expands to Row extends RowDataType<never>, which expands to

Row extends {
  dataKey?: string;
  children?: never[];
  [key: string]: any;
}

Nothing extends never[] | undefined other than never[] or undefined (as it's the bottom type). Any type that has a children value set will not work.

Changing this to unknown should work:

- const Table = React.forwardRef(<Row extends RowDataType, Key>(props: TableProps<Row, Key>, ref) => {
+ const Table = React.forwardRef(<Row extends RowDataType<unknown>, Key>(props: TableProps<Row, Key>, ref) => {

from rsuite-table.

@simonguo would you agree on this 👆 ?

from rsuite-table.

Hi, all

Could you provide a minimal example where the above problem occurs?

In addition, the latest version v5.18.1 supports getting the type-inferred Cell from children. Can this solve your problem?

https://github.com/rsuite/rsuite-table#type-safety

from rsuite-table.

Fixed in v5.18.2

from rsuite-table.