reduce dependencies about fontawesome HOT 9 CLOSED

Okay, so if a Shiny application wants to use this package they would need to install knitr then?

What about making knitr suggests and doing a requireNamespace() around the use of knitr::knit_print()?

from fontawesome.

I definitely think so. I’ll pare down so we just have to import htmltools and knitr.

from fontawesome.

Okay, great!

I could be wrong about this, but since htmltools implements knit_print for tags you might not need the knitr dependency either.

from fontawesome.

Ah, even better... hopefully it'll just depend on htmltools then.

from fontawesome.

Rewrote the main function fa() to have only the dependency on htmltools. Will investigate doing the same for the knit_print method.

from fontawesome.

It seems to me as if you shouldn't require the knit_print method at all (since the object is already a tag and tag implements knit_print as well).

from fontawesome.

FWIW, I believe that even if you have a knit_print method, you don't need to import anything from knitr.

from fontawesome.

We needed to use knitr::knit_print() in order to workaround the issue of FontAwesome icons in header-level text. Without this method, the icon rendering in headings wasn't correct.

from fontawesome.

The use of requireNamespace() has now been implemented. And, knitr was moved to the Suggests list.

from fontawesome.