Close `ReactiveSocket` on `DuplexConnection` close. about rsocket-java HOT 5 CLOSED

It seems a bit of a shame to lose AutoCloseable. it simplifies client usage, where often the synchronous close is useful with try-with-resources blocks.

from rsocket-java.

@yschimke I would like to hear more of the cases where try-with-resources is useful for real world applications. I would always end up doing Observable.concatWith(socket.close()) (in RxJava world ofcourse) as one can't really synchronously close the socket, it is always at the completion of an asynchronous call.

Having said that, I think we can always provide a utility method elsewhere which converts asynchronous close() to synchronous AutoClose implementation.

from rsocket-java.

technically this wouldn't close until someone request(n) the close - so that could be a little weird.

why not use a CompletableFuture?

from rsocket-java.

@NiteshKant I agree but would probably differentiate between expert users, and normal users.

I think making the simplest most Java idiomatic thing work correctly (but not optimally) is a cost worth paying. e.g. the clarity of the sample code that will be cut and paste everywhere.

It's a lot easier for users to go from correct+simpler -> correct+optimal once they care enough.

from rsocket-java.

0.5.x has close() and onClose() methods on ReactiveSocket. Closing this issue.

from rsocket-java.