Git Product home page Git Product logo

Comments (3)

rs avatar rs commented on July 20, 2024 1

As this header is added by the browser, as opposed to JS, I would assume the browser won't "ask" for permission before to send it and thus it is not necessary to whitelist it in CORS. Do you have an actual example where not specifically whitelisting this header is an issue?

from cors.

orangejulius avatar orangejulius commented on July 20, 2024

My mistake, I meant to say it is not sent by browsers and is instead set in application JS. So when that application JS sets the header, the browser will add Access-Control-Request-Headers: x-requested-with to the headers of the OPTIONS preflight request.

This header is commonly sent along by default in some frameworks, so yes it's always possible to turn it off. However since I do believe it's fairly common, it might make sense to add it to the defaults here.

It's also totally fine to say "X-Requested-With isn't in the CORS spec, so it's not going to be supported by default".

from cors.

rs avatar rs commented on July 20, 2024

Ok, feel free to send a PR. I don't think it's harmful to add it to the default.

from cors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.