Git Product home page Git Product logo

Comments (5)

knaeckeKami avatar knaeckeKami commented on September 24, 2024 1

Just as hint for anybody that also runs into this:
this is supported by json_serializable, but has to be enabled, either per class or globally via the
explicit_to_json flag in the build.yaml file.

Example:

@freezed
@JsonSerializable(explicitToJson: true)
abstract class MyModel with _$Model{ ... }
targets:
  $default:
    builders:
      json_serializable:json_serializable:
        options:
          explicit_to_json: true

from freezed.

rrousselGit avatar rrousselGit commented on September 24, 2024 1

@Holofox what you want is likely #50

from freezed.

rrousselGit avatar rrousselGit commented on September 24, 2024

Hi!
That's the job of json_serializable, not freezed.

Freezed is merely delegating that part to json_serializable.
Consider making an issue on their repository

from freezed.

Holofox avatar Holofox commented on September 24, 2024

@knaeckeKami, when using @JsonSerializable annotation, duplicate methods are created:

user.dart:

@freezed
@JsonSerializable(explicitToJson: true)
abstract class User with _$User {
  factory User({
    String id,
    String displayName,
    UserLanguage language,
  }) = _User;

  factory User.fromJson(Map<String, dynamic> json) => _$UserFromJson(json);
}

user.g.dart:

//This method is still created and used by Freezed
User _$UserFromJson(Map<String, dynamic> json) {
  return User();
}
//This method is created by @JsonSerializable
Map<String, dynamic> _$UserToJson(User instance) => <String, dynamic>{};

//This method is created by @JsonSerializable
_$_User _$_$_UserFromJson(Map<String, dynamic> json) {
  return _$_User(
    id: json['id'] as String,
    displayName: json['displayName'] as String,
    language: json['language'] == null
        ? null
        : UserLanguage.fromJson(json['language'] as Map<String, dynamic>),
  );
}
//This method is still created and used by Freezed
Map<String, dynamic> _$_$_UserToJson(_$_User instance) => <String, dynamic>{
      'id': instance.id,
      'displayName': instance.displayName,
      'language': instance.language,
    };

@rrousselGit, Is it possible to add the ability to change @JsonSerializable annotation properties through the freezed generator:

user.dart:

@freezed
abstract class User with _$User {
  factory User({
    String id,
    String displayName,
    UserLanguage language,
  }) = _User;

  @explicitToJson
  factory User.fromJson(Map<String, dynamic> json) => _$UserFromJson(json);
}

user.freezed.dart:

// Property passed to JsonSerializable annotation
@JsonSerializable(explicitToJson: true)
class _$_User implements _User {
  _$_User({this.id, this.displayName, this.language});

  factory _$_User.fromJson(Map<String, dynamic> json) =>
      _$_$_UserFromJson(json);

  @override
  final String id;
  @override
  final String displayName;
  @override
  final UserLanguage language;

  @override
  String toString() {
    return 'User(id: $id, displayName: $displayName, language: $language)';
  }

Do not judge strictly. I don’t know how annotations and generators interact with each other, but I tried to convey the problem.

from freezed.

knaeckeKami avatar knaeckeKami commented on September 24, 2024

Ah yes, it seems that you need to use the approach via the build.yaml at the moment

from freezed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.