Git Product home page Git Product logo

Comments (4)

rroemhild avatar rroemhild commented on May 10, 2024

This is great. I think a run-script is a good point to start with. We also can use that script to i.e. share the erlang cookie over etcd or set the hostname to cluster ejabberd instances.

I also like your idea to parse the config file with Jinja2. Setup the admin user with password could be another good run-time configuration. @swvitaliy addressed this in swvit-dl@9dfefa7.

Other interesting forks we maybe can merge from:

I will read the 12factor document to get a better idea. And merge your requests later this day.

from docker-ejabberd.

benlangfeld avatar benlangfeld commented on May 10, 2024

erlang cookie from etcd

My preference would be to leave this out of the image in a tool which orchestrates the containers and passes this in as an environment variable. Happy to have the run script set the cookie at runtime from the environment variable, though. I'll submit a PR for that.

Setup the admin user with password

This opens some extra questions about clustering and persistence of state. I'll stay away from this for the moment.

from docker-ejabberd.

rroemhild avatar rroemhild commented on May 10, 2024

Logging to stdout inclusive extra logfiles, done.
Graceful shutdown on SIGTERM and SIGINT, done.
Config in the runtime environment, done.

Please re-open if you do not agree.

from docker-ejabberd.

benlangfeld avatar benlangfeld commented on May 10, 2024

Awesome, thanks for all of that work @rroemhild and sorry I couldn't free myself up to contribute more recently.

from docker-ejabberd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.