Git Product home page Git Product logo

Comments (11)

AlexAltea avatar AlexAltea commented on May 21, 2024

Interesting, thanks for the info! πŸ˜„ I wrote on Emunewz some time ago about issues with the PSL1GHT samples: http://www.emunewz.net/forum/showthread.php?tid=149835
Hmm.. I thought that part of rpcs3 was working perfectly. :-/

from rpcs3.

elisha464 avatar elisha464 commented on May 21, 2024

is it possible to make a call stack for the disassembler interface? it will really help with debugging things

from rpcs3.

AlexAltea avatar AlexAltea commented on May 21, 2024

Nice idea! If DH agrees with this, I will take care of the feature. ;-)

from rpcs3.

AlexAltea avatar AlexAltea commented on May 21, 2024

@elisha464: You are probably looking for this. I hope you find it useful:
Binary: http://www.mediafire.com/download/j4aneqok4w7fwbd/rpcs3-x86-call-stack.exe

callstack

@DHrpcs3:
Patch: http://rghost.net/50340219
I'm not sure if you are going to like the changes made. I had to add an extra line to 2 PPU Instructions bl and blr in order to push and pop respectively the address to a Stack. Then it's written to a text box in a similar manner to WriteRegs(). Tell me if you agree with this. πŸ˜„

from rpcs3.

elisha464 avatar elisha464 commented on May 21, 2024

ok, I just realized that a call stack might not be that useful because of mflr and mtlr :(, I'll keep trying though, but its going to be hard

from rpcs3.

elisha464 avatar elisha464 commented on May 21, 2024

I think I found a bug, you tell me
I have this situation
GPR[8] = 0x1
GPR[9] = 0x1f

and I'm trying to do
sld r8, r8, r9

what should be the result of r8?
0x0
or
0x80000000

right now, the emulator gives 0x0

from rpcs3.

elisha464 avatar elisha464 commented on May 21, 2024

fix suggestion
PPUInterpreter.h line 2367

void SLD(u32 ra, u32 rs, u32 rb, bool rc)
{
    RLDICR(ra, rs, CPU.GPR[rb], 63 - CPU.GPR[rb], rc);
    /*const u32 n = CPU.GPR[rb] & 0x3f;
    const u64 r = rotl64(CPU.GPR[rs], n);
    const u64 m = (CPU.GPR[rb] & 0x30) ? 0 : rotate_mask[0][63 - n];

    CPU.GPR[ra] = r & m;

    if(rc) CPU.UpdateCR0<s64>(CPU.GPR[ra]);*/
}

reference
fiximg

it seems to work, I dont know if it'll break anything or if its not optimized, its just a suggestion

from rpcs3.

AlexAltea avatar AlexAltea commented on May 21, 2024

@elisha464: Does DHrpcs3@aab6951 fix this issue?

from rpcs3.

elisha464 avatar elisha464 commented on May 21, 2024

yes, it does, finally the video samples of PSL1GHT initialize the rsx thread :), another big step in compatibility, who would have though that one instruction will ruin everything

from rpcs3.

AlexAltea avatar AlexAltea commented on May 21, 2024

Great! Thank you so much for debugging this! πŸ˜„

from rpcs3.

elisha464 avatar elisha464 commented on May 21, 2024

just doing my part :P

from rpcs3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.