Ask user for reboot after enabling module about xposedinstaller HOT 5 CLOSED

Offering to reboot after installing the framework would be more in line with the new install-via-recovery mode, which also offers to reboot to recovery automatically. So maybe I'll add a normal reboot option there.

For enabling modules, I think it would be too annoying to get a popup everytime you click on the checkbox to enable or disable a module. And not to forget, it makes new users forget even more that they need to reboot after updating any module. So I'd rather not add a reboot option here.

from xposedinstaller.

So maybe display popup when leave activity similar to AppSettings?

2014/1/20 rovo89 [email protected]

Offering to reboot after installing the framework would be more in line
with the new install-via-recovery mode, which also offers to reboot to
recovery automatically. So maybe I'll add a normal reboot option there.

For enabling modules, I think it would be too annoying to get a popup
everytime you click on the checkbox to enable or disable a module. And not
to forget, it makes new users forget even more that they need to reboot
after updating any module. So I'd rather not add a reboot option here.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/95#issuecomment-32799573
.

from xposedinstaller.

So offer reboot when returning from modules section if there are some inactived modules? Sounds good.

from xposedinstaller.

I appreciate your ideas, but please don't push me! It's probably not intended, but it gives me the feeling that I need to hurry up. You know what I did in the past 19 hours? I have slept and worked (yes, I have a full time job). Apart from that, I also have other hobbies, like meeting friends (which I will do this evening) and build a home entertainment system. The time I spent for Xposed in the past 1-2 weeks was mainly used to answer forum questions and so on. Not much code written. That's fine for me and I believe it is fine for you as well, so please just give me the time I'm willing to spend.

Back to the suggestion. Displaying a popup if you have changed any checkboxes makes sense at first sight, however there's a catch. I wouldn't want to make it even more complicated by offering soft reboot AND full reboot. To be on the safe side, I would offer a full reboot. So for those users who are used to navigating to the framework section and clicking the soft reboot button, the popup would be annoying. I include myself here. Not sure if that would be worth the 3 clicks it safes for other users (open the dropdown, click "framework", click "(soft) reboot").

from xposedinstaller.

Oh no. Bad to hear that :(
I dont push you and dont want do that. I just want share some ideas and complete/fix translation and maintain it (i didnt saw next branch so i said you to merge it, of course, i will upload everything (fixes and new strings) in right time, when you will ask it)
If you want, feel free to close this issue..
All hats goes down before you because you are one of TOP android devs of all the time for sure.

from xposedinstaller.