Embedded images are not loaded about xposedinstaller HOT 25 CLOSED

It's not supported, yet. A dedicated screenshot page in the Download ->
Module section might be added in a future release according to rovo.
Am 13.06.2014 19:53 schrieb "pyler" [email protected]:

I am not sure if we want this...

http://i.imgur.com/f6pW6sR.png (
http://repo.xposed.info/module/hk.kennethso168.xposed.advancedrebootmenu)

—
Reply to this email directly or view it on GitHub
#200.

from xposedinstaller.

Yes, the ImageGetter isn't implemented. It's not trivial to take care of downloading the images asynchronously, update the TextView when they are loaded etc. It also requires a good cache management to ensure a proper balance between traffic/server load and storage usage.

from xposedinstaller.

The are plenty good libraries to use but I goes we want to save apk size,
isn't it?

If that's not the case I'd volunteer to help implementing it.
Am 13.06.2014 21:40 schrieb "rovo89" [email protected]:

Yes, the ImageGetter isn't implemented. It's not trivial to take care of
downloading the images asynchronously, update the TextView when they are
loaded etc. It also requires a good cache management to ensure a proper
balance between traffic/server load and storage usage.

—
Reply to this email directly or view it on GitHub
#200 (comment)
.

from xposedinstaller.

If you have a suggestion for a library, let me know. It's rather low priority for me though.

from xposedinstaller.

Maybe koush's ion library?

If think we dont need to embedd these images at all. images links are okay too.

from xposedinstaller.

I'd suggest a dedicated screenshot tab. The description is the first tab to
be shown which would lead to loading the images every time. If any of you
knows the Windows Store on Windows Phone you'll know what I mean. If the
user really wants to see screenshots he can swipe to the right most page.

I downloaded one lib today which was 100kb. I'll post something later.
Am 13.06.2014 22:02 schrieb "pyler" [email protected]:

Maybe koush's ion library?

If think we dont need to embedd these images at all. images links are okay
too.

—
Reply to this email directly or view it on GitHub
#200 (comment)
.

from xposedinstaller.

The ion library is huge, about the same size as the Xposed Installer APK including all assets and translations. I think it's overkill.

But I also like the idea of simply turning images into links (unless they are already linked). Apart from loading the images, they would also need to be downsized, have a fullscreen view etc.

from xposedinstaller.

After reading this on Stackoverflow I think Android-Universal-Image-Loader is the best lib and it's also the most common one. So we can assume it's maintained. It's current size is 155kb.

Currently I'm implementing a UI which loads all icons from an icon pack and lets the user pick an icon. I've made my own implementation of async loader (see demo here). So I'll try and use the AUIL lib instead and let you know. Okay?

from xposedinstaller.

But Picasso is 55kb lighter and it focuses on network loading only (if I read right). It's usage seems pretty easy, too.

Picasso.with(context).load("http://i.imgur.com/DvpvklR.png").into(imageView);

from xposedinstaller.

Keep in mind that at least currently, the description is displayed via a simple text view after parsing the HTML. Does any of these libraries have support for that? We would probably need placeholders while the image is loading, a preview, click-to-fullscreen and so on. And I'm not sure if it's worth the effort and complexity. A separate screenshots section would be cleaner and easier in my opinion.

Note that there is already some logic to download a file:
https://github.com/rovo89/XposedInstaller/blob/master/src/de/robv/android/xposed/installer/util/RepoLoader.java#L293
I have just refactored the relevant parts out into DownloadUtils for something else (not on GitHub) yet, so it could be reused. This executed in the background, combined with an time- and recent-usage-based cache, might be all it takes.

from xposedinstaller.

I was already speaking of the dedicated screenshot page.

We could also grep for and put those in the screenshot section
and remove it from the description automatically.
Am 14.06.2014 13:10 schrieb "rovo89" [email protected]:

Keep in mind that at least currently, the description is displayed via a
simple text view after parsing the HTML. Does any of these libraries have
support for that? We would probably need placeholders while the image is
loading, a preview, click-to-fullscreen and so on. And I'm not sure if it's
worth the effort and complexity. A separate screenshots section would be
cleaner and easier in my opinion.

Note that there is already some logic to download a file:

https://github.com/rovo89/XposedInstaller/blob/master/src/de/robv/android/xposed/installer/util/RepoLoader.java#L293
I have just refactored the relevant parts out into DownloadUtils for
something else (not on GitHub) yet, so it could be reused. This executed in
the background, combined with an time- and recent-usage-based cache, might
be all it takes.

—
Reply to this email directly or view it on GitHub
#200 (comment)
.

from xposedinstaller.

I suggest keeping screenshot in a separate field on the site, rather than having them inlined in the description, this gives a cleaner look imo.

Similar to how authors can be added, screenshots can be added on a per line basis.
I'd say using imgur or a similar site would be better than hosting them on the server, that shouldn't cause much load.

In the app itself, a separate section above the description would be best, similar to how the Play Store does it.

If you're willing to accept that, I may have some time to work on it, but I'd need the changes on the server to be done.

from xposedinstaller.

I'm against making them visible all the time. It'll use data only to load
pictures I don't want to see. I'm on a limited data mobile contract because
I'm too greedy to buy a bigger one. Opening Google Play always loads lots
of pictures immediately using my data contingent.

Furthermore if you are on 2G there will be a loading picture the whole time
until it gets completely loaded. That's why I prefer the screenshot section
on a seperate tab.
Am 22.06.2014 15:51 schrieb "Mohammad Abu-Garbeyyeh" <
[email protected]>:

I suggest keeping screenshot in a separate field on the site.
Similar to how authors can be added, screenshots can be added on a per
line basis.
I'd say using imgur or a similar site would be better than hosting them on
the server, that shouldn't cause much load.

In the app itself, a separate section above the description would be best,
similar to how the Play Store does it.

—
Reply to this email directly or view it on GitHub
#200 (comment)
.

from xposedinstaller.

A screenshot tab won't fix your issue (you're forgetting about the ViewPager's caching/preloading), a setting to disable image downloads will... So better do it the right way. ;)

from xposedinstaller.

Well, it can be a button based implementation (click to load screenshots), but I'm talking basic implementation right now.

Separate would be much better than inlining them.

from xposedinstaller.

Here's what I was thinking for the server:

http://i.imgur.com/bIj3jg0.png

from xposedinstaller.

@GermainZ I know it'll pre load the page but we could avoid loading the
images before actually swiping to the page.

I didn't mention it because this was a basic discussion, not a technical
one.
Am 22.06.2014 15:57 schrieb "GermainZ" [email protected]:

A screenshot tab won't fix your issue (you're forgetting about the
ViewPager's caching/preloading), a setting to disable image downloads
will... So better do it the right way. ;)

—
Reply to this email directly or view it on GitHub
#200 (comment)
.

from xposedinstaller.

Here's what I was thinking for the server:

http://i.imgur.com/bIj3jg0.png

Yep, that's exactly how I planned it. I'm also worried about the traffic it would cause, so off-loading sounds like a good idea. Not sure how reliable imgur is, but I've seen it around a lot. And I could still download the images to my server as a backup, also to check whether the URL indeed points to a valid image.

Generally, I'd prefer a separate tab as well. Whether they are loaded automatically (and when) or whether you have to press a button needs to be discussed before implementing this, but that are already details.

Guys, please keep in mind that Google I/O is next week, so we'll most likely get the new Android version then. I will really need to concentrate on the new stuff (ART, stricter SELinux, dualstack Zygote), so please don't be disappoint if I postpone this topic a bit.

from xposedinstaller.

ART will be a hard time. I recommend you staying away from XDA and github
until you've finished your work. It's even annoying for me and I'm not even
the one who needs to implement it. We'll run the threads for you ;)
Am 22.06.2014 16:13 schrieb "rovo89" [email protected]:

Here's what I was thinking for the server:

http://i.imgur.com/bIj3jg0.png

Yep, that's exactly how I planned it. I'm also worried about the traffic
it would cause, so off-loading sounds like a good idea. Not sure how
reliable imgur is, but I've seen it around a lot. And I could still
download the images to my server as a backup, also to check whether the URL
indeed points to a valid image.

Generally, I'd prefer a separate tab as well. Whether they are loaded
automatically (and when) or whether you have to press a button needs to be
discussed before implementing this, but that are already details.

Guys, please keep in mind that Google I/O is next week, so we'll most
likely get the new Android version then. I will really need to concentrate
on the new stuff (ART, stricter SELinux, dualstack Zygote), so please don't
be disappoint if I postpone this topic a bit.

—
Reply to this email directly or view it on GitHub
#200 (comment)
.

from xposedinstaller.

Indeed it will, but I doubt we'll see a rollout in I/O, and if we do, the majority will still be on 4.4.2 for a while.

Anyway, I'd appreciate if you could just add the barebones to Drupal (for at least one module) so I (or someone else) could focus on it, and you could focus on the new stuff.

from xposedinstaller.

ART will be a hard time. I recommend you staying away from XDA and github until you've finished your work. It's even annoying for me and I'm not even the one who needs to implement it. We'll run the threads for you ;)

Thanks. ;) I'm actually more worried about SELinux. Implementation-wise, I got Xposed working for the preview version of ART a while ago (I spent a lot of time on that already). It doesn't compile against master, so adjustments will definitely be necessary, and probably intensive testing will bring up more issues, but it seems doable. SELinux is much more uncertain, especially because it affects not only the framework, but also the modules.

Anyway, I'd appreciate if you could just add the barebones to Drupal (for at least one module) so I (or someone else) could focus on it, and you could focus on the new stuff.

Is it necessary to have it in Drupal first? I already added a "screenshots" list to the Module class in Java , it's even parsed already from the XML. So for testing, you could simply fill that list after parsing or add a secondary repository with a hand-written XML.

If someone wants to work with it, please consider these points or discuss with me beforehand if you think it would be better not to follow them:

• Image loading must be asynchronous (no big surprise). For the first implementation, it doesn't matter much what triggers it. Eventually, I guess there should be an option to toggle between automatic and manual download. Or maybe it should be based on Wifi status, but that shouldn't be in the first version.
• The downloaded images should be cached on the disk. I think an LRU algorithm would make sense, please maybe a cleanup of old images from time to time.
• The code used to download the repo.xml should be considered for reuse. It could be extended to be more generic.
• As mentioned, I would like to see screenshots in a separate tab.
• Clicking on an image to see it in fullscreen would be nice.

from xposedinstaller.

Maybe introduce field in repo for screenshot URL? Just like for source code URL for example. And add another "tab" to see screenshot. Pros/cons?

from xposedinstaller.

No objections from my side. Adding the field to Drupal and writing it to the XML is not a big deal, takes about an hour. I don't have the time to implement the Android part though. So if anyone wants to take care, my list of ideas/requirements can be found above (which would be in addition to the usual quality expectation, e.g. matching the existing code style and building a sustainable solution).

from xposedinstaller.

Maybe you can write public TODO list ;)

from xposedinstaller.

I can take up the Android part I suppose.

from xposedinstaller.