Git Product home page Git Product logo

Comments (6)

ndw avatar ndw commented on July 4, 2024 2

Thanks, @mclearc that did the trick. I'll make a PR, since I've got it "right here".

from nano-emacs.

rougier avatar rougier commented on July 4, 2024

I'm not using helm so I'm not sure what is the problem. Starting with this configuration and if you remove anything nano related, does it work as expected? If yes, can you start adding nano files one by one to check which one is faulty?

from nano-emacs.

mclearc avatar mclearc commented on July 4, 2024

I found I had to add helm faces in a specific way (note the various functions) though haven't tested this lately, but you might give it a try first (put this in nano-theme.el):

(defun nano-theme--helm ()
  "Derive helm faces from nano faces."
  (with-eval-after-load 'helm
    (set-face 'helm-selection                '(nano-face-strong nano-face-subtle))
    (set-face 'helm-match                                       'nano-face-strong)
    (set-face 'helm-source-header                              'nano-face-salient)
    (set-face 'helm-visible-mark                                'nano-face-strong)))

(defun nano-theme--helm-swoop ()
  "Derive helm faces from nano faces."
  (with-eval-after-load 'helm-swoop
    (set-face 'helm-swoop-target-line-face   '(nano-face-strong nano-face-subtle))))

(defun nano-theme--helm-occur ()
  "Derive helm faces from nano faces."
  (with-eval-after-load 'helm-occur
    (set-face 'helm-moccur-buffer                               'nano-face-strong)))

(defun nano-theme--helm-ff ()
  "Derive helm faces from nano faces."
  (with-eval-after-load 'helm-ff
    (set-face 'helm-ff-file                                      'nano-face-faded)
    (set-face 'helm-ff-prefix                                   'nano-face-strong)
    (set-face 'helm-ff-dotted-directory                          'nano-face-faded)
    (set-face 'helm-ff-directory                                'nano-face-strong)
    (set-face 'helm-ff-executable                               'nano-face-popout)))

(defun nano-theme--helm-grep ()
  "Derive helm faces from nano faces."
  (with-eval-after-load 'helm-grep
    (set-face 'helm-grep-match                                  'nano-face-strong)
    (set-face 'helm-grep-file                                    'nano-face-faded)
    (set-face 'helm-grep-lineno                                  'nano-face-faded)
    (set-face 'helm-grep-finish                                'nano-face-default)))

from nano-emacs.

rougier avatar rougier commented on July 4, 2024

By the way, for the mu4e customization, you don't need to use nano at all. You can only use the nano-mu4e.el and adapt the few faces that are required (only four I think).

For the helm problem, the culprit seems to be helm-swoop, is that right? if yes, I can have a look at the code to see if I can find something strange inside.

from nano-emacs.

mclearc avatar mclearc commented on July 4, 2024

If I'm remembering correctly, the problem is that helm-swoop (and other parts of helm) are not all loaded when helm itself is, so the single with-eval-after-load call isn't enough. Hence the separate loading of helm parts as described above.

from nano-emacs.

rougier avatar rougier commented on July 4, 2024

You mean the above init splitting works as intended ? If so, can you make a PR?

from nano-emacs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.