Git Product home page Git Product logo

Comments (15)

ndw avatar ndw commented on August 27, 2024 2

Done.

from nano-emacs.

ndw avatar ndw commented on August 27, 2024

I should have said, this is an Emacs 27.1 that I compiled myself on MacOS.

from nano-emacs.

rougier avatar rougier commented on August 27, 2024

Thanks for the report. I'm not too familiar with byte compilation and I don't quite understand why the byte compiled code would fail. If you comment out the faulty line, compilation is ok?

from nano-emacs.

ndw avatar ndw commented on August 27, 2024

It compiles just fine, that's an error I get when the compiled code runs. For the moment, I've just deleted nano-layout.elc.

from nano-emacs.

rougier avatar rougier commented on August 27, 2024

From the error, the faulty line is around L44. Can you check if you comment it ?

from nano-emacs.

ndw avatar ndw commented on August 27, 2024

If I comment out that line (and the set-display-table-slot below it, for good measure), the error does not occur. I can't tell what other effect this might have though. I'm not sure what that code is supposed to accomplish.

from nano-emacs.

rougier avatar rougier commented on August 27, 2024

This line replaces the default continuation character ($) with a nicer glyph (…) . No idea why byte compiling it poses a problem. Maybe you can test this line with emacs -q and check if the problem persists. In such case, you would need to report the problem to emacs+bug.

from nano-emacs.

baod-rate avatar baod-rate commented on August 27, 2024

Could this have to do with the font? Not sure how the bytecode compilation process works (or how fonts are handled, I'm new to emacs), but the error went away when I installed Fira Code (I had neither Fira Code nor Roboto installed in my system)

from nano-emacs.

rougier avatar rougier commented on August 27, 2024

That might be an explanation yes if the compiled code doesn't do all the checks on the availability of fonts.

from nano-emacs.

brongulus avatar brongulus commented on August 27, 2024

Hi I'm facing the same error even when I have both the fonts installed on my system, and I commented out the lines and checked too, the error persists. Any insight?

from nano-emacs.

rougier avatar rougier commented on August 27, 2024

Do you mean that you get the same behavior with/without faulty line when compiling?

from nano-emacs.

ndw avatar ndw commented on August 27, 2024

I noticed that I didn't have Fira Code installed and wondered if that was it. It wasn't. I've now got both Fira Code and Roboto Mono installed and I'm still getting the same error. Emacs 27.1.91 built by me in March on MacOS.

I poked at it a bit more without any luck. I did observe the following, however: nano-layout contains a reference to 'nano-face-faded:

(defface fallback '((t :family "Fira Code"
                       :inherit 'nano-face-faded)) "Fallback")
(set-display-table-slot standard-display-table 'truncation
                        (make-glyph-code ?… 'fallback))

FWIW, that face isn't defined until 'nano-faces is loaded. But my random attempt to load the faces before loading layout didn't have any effect.

from nano-emacs.

rougier avatar rougier commented on August 27, 2024

Good point. Can you try to remove the inherit part (or replace with default) and check if this solves the problem?

from nano-emacs.

ndw avatar ndw commented on August 27, 2024

While I'm no closer to understanding what the problem is, I've managed to completely separate it from NΛNO. Put the following lines in testdt.el:

(message "Hello")
(describe-display-table standard-display-table)
(message (format "%s" (char-table-p standard-display-table)))
(message "Goodbye")

Start emacs: emacs -q -l testdt.el

You'll get this in the *Message* buffer:

For information about GNU Emacs and the GNU system, type C-h C-a.
Hello
Type C-x 1 to delete the help window.
t
Goodbye

And this in the *Help* buffer:

Truncation glyph: nil
Wrap glyph: nil
Escape glyph: nil
Ctrl glyph: nil
Selective display glyph sequence: nil
Vertical window border glyph: nil
Character display glyph sequences:

Now byte compile the file and start emacs: emacs -q -l testdt.elc

You'll get an the wrong-type-argument error and the *Messages* buffer will contain:

For information about GNU Emacs and the GNU system, type C-h C-a.
Hello
display-table-slot: Wrong type argument: char-table-p, nil

The *Help* buffer will contain:

Truncation glyph: 

So there's something wrong with attempting to access the standard-display-table from byte compiled code.

I've no clue what to do next with this information. I'm not on the Emacas developers list anymore, maybe it's time to send it there?

from nano-emacs.

rougier avatar rougier commented on August 27, 2024

I think you can directly file a bug from inside emacs (M-x report-emacs-bug) with your explanation.

from nano-emacs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.