Git Product home page Git Product logo

Comments (6)

mikeferguson avatar mikeferguson commented on August 24, 2024 1

So, it looks dashing has version 1.0 released into it - the node has been renamed to "urg_node_driver". I've opened a PR to fix the documentation: #70

It should be noted that the node still doesn't run because of #66 - see my patch there (I haven't opened a PR yet for that one, cause I'm not sure it's the "right" fix).

from urg_node.

mikeferguson avatar mikeferguson commented on August 24, 2024 1

See also #71 - which should fix the run() issue in #66

from urg_node.

mikeferguson avatar mikeferguson commented on August 24, 2024 1

Fixed in version 1.0.1:

from urg_node.

ShotaAk avatar ShotaAk commented on August 24, 2024

I tried to make an executable node that executes UrgNode.run().
The node publish /scan topic successfully.

Source code of the executable node (urg_node_executable.cpp)

#include <memory>
#include "rclcpp/rclcpp.hpp"

#include "urg_node/urg_node.hpp"

int main(int argc, char * argv[])
{
  rclcpp::init(argc, argv);
  rclcpp::executors::SingleThreadedExecutor exec;
  rclcpp::NodeOptions options;
  auto urg_node = std::make_shared<urg_node::UrgNode>(options);

  urg_node->run();

  exec.add_node(urg_node);
  exec.spin();
  rclcpp::shutdown();
}

New lines of the CMakeLists.txt

add_executable(urg_node_executable src/urg_node_executable.cpp)
target_link_libraries(urg_node_executable urg_node)
ament_target_dependencies(urg_node_executable
  rclcpp)

install(TARGETS urg_node_executable
  DESTINATION lib/${PROJECT_NAME}
)

( Actually, I wanted to change names urg_node to urg_node_component, urg_node_executable to urg_node.)

To reproduce:

  1. Run ros2 run urg_node urg_node_executable __params:=$HOME/ros2_ws/src/urg_node/launch/urg_node_serial.yaml
  2. Run ros2 run tf2_ros static_transform_publisher 0 0 0 0 0 0 "world" "laser"
  3. Run rviz2

Result:
image

from urg_node.

mikeferguson avatar mikeferguson commented on August 24, 2024

1.0.1 released to foxy: ros/rosdistro#25425

from urg_node.

ShotaAk avatar ShotaAk commented on August 24, 2024

@mikeferguson thank you for fixing and updating the package!

from urg_node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.