Git Product home page Git Product logo

Comments (5)

shrektan avatar shrektan commented on June 6, 2024

I think this is because it's easier to implenment when calculating the correct the Excel numeric value of the datetime object, as R stores the datetime numeric value based on the UTC 1970-01-01 00:00:00, regardless of the timezone ... I find this inconvinient, too.

from writexl.

jmcnamara avatar jmcnamara commented on June 6, 2024

Excel doesn't have support for timezones and stores everything as UTC. So unfortunately, this isn't really fixable.

I vote to close as can't/won't fix.

from writexl.

mrchypark avatar mrchypark commented on June 6, 2024

writexl::write_xlsx() function just write datetime data as string like "2021-04-17 14:16:40 UTC".
https://github.com/ropensci/writexl/blob/master/src/write_xlsx.c#L89

So, My suggestion is write datetime data with timezone text like "2021-04-17 23:16:17 KST".

xlsx is not only database for machine, but also communication docs with human.

I think datetime storing as string with tz is good to R user work with others.

from writexl.

jmcnamara avatar jmcnamara commented on June 6, 2024

I think datetime storing as string with tz is good to R user work with others.

That is certainly fine and that can be done by the user in the dataframe before exporting it, i.e., they can convert a datetime column to a character string column.

However, I don't think that it would be a good solution to export all datetimes to Excel as strings. This would prevent users from doing calculations based on them or graphing them.

So I think writexl should honour the conversion from R datatypes to Excel data types (where possible). Users will have to work around the Excel limitation of losing the timezone information.

from writexl.

mrchypark avatar mrchypark commented on June 6, 2024

@jmcnamara

Thanks for the great comment.

I first noticed that Excel does not support time zones.

I understand that the current writexl package does not use Excel's datetime type as long as it is processed as a string. So, I asked if we intended to treat it as a string. My feedback was provided as an improvement in the current state.

from writexl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.