Comments (10)
Not from the unconf, but something to elevate to updated guidance for authors, from the review of rnaturalearth:
If you feel your reviewers have substantially contributed to the development of your package, we suggest you credit them in the DESCRIPTION file
Authors:
field as reviewers, like so:
person("Lincoln", "Mullen", role = c("rev"))
from software-review.
Seems like a good idea - can you add to guide for authors
from software-review.
Done. Also, new life goals for how I am listed in a future package:
> utils:::MARC_relator_db[utils:::MARC_relator_db$code %in% c('wde', 'wdc'),]
term code description usage
260 Wood engraver wde A person or organization who makes prints by cutting the image in relief on the end-grain of a wood block
261 Woodcutter wdc A person or organization who makes prints by cutting the image in relief on the plank side of a wood block
from software-review.
I think we want a formatted report rather than just logs, with things ordered from most important (editor-rejects) to 'useful to know' info for reviewers.
Other things to potentially run in the the check/put in the report:
- Just the NOTES/WARNINGS/ERRORS from R CMD Check
- exported functions use the same naming style
- what CI service is being used? (A Linux AND Windows CI?)
- README.Rmd is used if there is substantial code in README
- Lines of code in .R files, Roxygen comments, and tests (I think measuring this and a little more experience might be useful before we move to limiting review size).
- List of packages in
Depends
- Is there a code of conduct?
print()
orcat()
calls in functions
from software-review.
I think I'm going to start a discuss thread for reviewers to ask them what would be useful in an automated report.
from software-review.
Haha that's awesome - your code confirms that my guess of 'rev' was about right - not sure why R packages need wood engravers though - maybe to ensure their longevity after the internet goes down? ;)
utils:::MARC_relator_db[utils:::MARC_relator_db$code %in% c('rev', 'wdc'),]
term code description
223 Reviewer rev A person or organization responsible for the review of a book, motion picture, performance, etc.
261 Woodcutter wdc A person or organization who makes prints by cutting the image in relief on the plank side of a wood block
usage
Many thanks @noamross for showing me what those codes mean - any more info where those codes come from appreciated.
from software-review.
start a discuss thread
okay
from software-review.
@Robinlovelace A little googling reveals that these are codes for MARC bibliographic standards, which are what Library of Congress uses for metadata: http://www.loc.gov/marc/ , https://www.loc.gov/marc/relators/relaterm.html
from software-review.
Thanks for the info - impressed R incoroporates those codes into person()
- apologies for being slow, see now that's also linked to in ?person
.
from software-review.
discussion at https://discuss.ropensci.org/t/what-additional-automated-checks-would-be-useful-for-package-review/347
from software-review.
Related Issues (20)
- gigs: Assess Fetal, Newborn, and Child Growth with International Standards HOT 8
- dendroNetwork HOT 50
- eDNAjoint: an R package for interpreting paired environmental DNA and traditional surveys HOT 16
- Capybara HOT 9
- Presubmission inquiry: `chopin` HOT 2
- Presubmission enquiry for cocoon: Extract, Format, and Print Statistical Output HOT 3
- QuadratiK: A Collection of Methods Using Kernel-Based Quadratic Distances for Statistical Inference and Clustering HOT 52
- osmapiR: an implementation of OpenStreetMap API v0.6 for R HOT 89
- ## Reply to package review by @njtierney HOT 3
- cancerprof: API Client for extracting data from State Cancer Profiles HOT 3
- rsi: Efficiently Retrieve and Process Satellite Imagery HOT 44
- cancerprof: API Client for extracting data from State Cancer Profiles HOT 41
- `chopin`: Computation for Climate and Health research On Parallelized INfrastructure HOT 54
- rpigpior HOT 13
- phangorn HOT 2
- eDNAjoint: R package for interpreting paired environmental DNA and traditional surveys HOT 44
- Presubmission Inquiry of the `cryptoQuotes`-package HOT 6
- Capybara HOT 22
- QuickJSR - Portable, lightweight JavaScript engine for R
- feowR: Download shapefiles of Freshwater Ecoregions of the World (FEOW) HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from software-review.