Comments (10)
Yes, I'll get to that over the weekend.
from relter.
I've pushed a better example.
from relter.
do you think to add a show_map
parameter also for this function?
from relter.
Yes, why not?
After tomorrow ;-)
from relter.
yes of course!!!
from relter.
Hi @oggioniale : I have a suggestion here. I would like to prepare a single function relter_display_map()
to be used throughout the package. That way we will be showing uniform maps, and it saves a lot of duplicated code. I would define the function with 2 parameters: raster_layer and vector_layer. (At least one would be required). And I suggest to base the map display on tmap
since with that package it's easier to handle raster data compared to leaflet. Then, in all the functions that have code to show maps, I would replace with a simple call to this new function.
What do you think?
from relter.
@micha-silver
do you think of an internal function?
This could be a good solution also because some functions, currently, don't have the show_map parameter.
My doubts is about to the abstraction of the values contained in the relter_display_map()
function and how to activate this in other functions.
from relter.
@oggioniale : Yes, an internal function. Not exported
Once this is working, it will be trivial to add show_map
to other functions.
We will need to pass to the function either an sf
(vector) object or a terra
raster.
from relter.
@micha-silver if you have more clear that me how to build this please. But take care that a strong modification to the functions must take into account the test, and probably, any modifications must consider the test files.
I suggest to propose modification in a new branch that cover specific issue.
from relter.
Good idea, I'll start a new branch dev-display-maps
for this and begin to make changes. Then we'll see how it goes...
from relter.
Related Issues (20)
- change the logo of the package
- pkgdown build error HOT 53
- Release ReLTER 1.2.0
- Remove dependency on RCurl and XML
- Normalize DESCRIPTION HOT 1
- Resources on dependencies limitations HOT 4
- Viewing maps HOT 1
- Size of repo - figures...
- get_site_MODIS doesn't seem to use credentials from setenv
- PhenoAppLyon
- taxon_id_pesi
- rm docs folder HOT 4
- remove rgeos from description file HOT 2
- What does Rdpack::reprompt() do? HOT 2
- error when knitting sites_contact.Rmd HOT 4
- No need to load testthat in individual test files HOT 1
- suggestion: use the withr package HOT 4
- Remove dependency on RCurl HOT 3
- A package that might be relevant for ReLTER
- Actions fail for no CRAN package (MODIStsp) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from relter.