Allow 31 as day.impute about datefixr HOT 6 CLOSED

No problem, thanks!

I just need to update some packages before I can install (rlang, vctrs, Rcpp), but will do this once I've sorted that!

from datefixr.

Absolutely! day.impute $\leq$ 28 was a simple way of ensuring days of the month never went out of bounds, but a system which takes into account the actual days in each month (factoring in leap years) is definitely needed. I'll get to work work on this.

from datefixr.

Thanks Nathan, let me know if I can be of any help!

from datefixr.

Thanks! I've just pushed a change which allows day.impute = 31. Days won't go out of bounds for each month so setting day.impute=31 will result in the last day of the month being imputed for missing days. At the moment the changes are on the devel branch.

If you could please install from this branch,

remotes::install_github("ropensci/datefixR", "devel")

and let me know if that works for your use case, that would be great!

from datefixr.

Hi Nathan - it's definitely working, thanks!

from datefixr.

Brilliant! Thanks. I will merge into main now. The change should be propagated to CRAN in about two weeks.

from datefixr.