Comments (9)
Good observation! Thank you!
It's not surprising given that the comparison algorithm is purposely simple. Maybe we could change the way EUROEVOL is loaded to add the hyphens? What do you think?
from c14bazaar.
Grrr. I had a look at the original EUROEVOL-dataset, and it is not consistent even there: Sometimes there are hyphens, sometimes there are spaces and sometimes neither. I think a parsing line (with catering for the three cases) should be entered here: c14age = .data[["C14Age"]],
from c14bazaar.
Are you sure that you have pushed your changes? I can see no differences.
from c14bazaar.
The changes are only in the specific branch for this issue.
You can install the version with them with devtools::install_github("ISAAKiel/c14bazAAR#61")
from c14bazaar.
Okay, I did not realize you created a new branch.
Indeed, there is an unexpected result: Some CALPAL-dates now have two hypens (e.g. UtC--10808
). I suspect an ASCII-character that only looks like a hyphen.
from c14bazaar.
Thank you for testing!
The CalPal dates already had the double hyphens. I defined another case to solve this.
from c14bazaar.
Another case: Duplicate entries in the same database (RADON):
KN-1531
KN-I.531
from c14bazaar.
I don't think we can capture errors like this automatically. Or is there a systematic (!) difference that applies to many date pairs?
For individual errors: Please contact the authors of RADON.
from c14bazaar.
I think you can merge this branch. At least for me it works as expected and produced no detrimental results.
from c14bazaar.
Related Issues (20)
- Rework the duplicate removal interface HOT 1
- Database version update
- Input argument checking
- openxlsx reading issues HOT 4
- IntChron parser HOT 6
- CRAN submission ToDo list HOT 5
- Country thesaurus includes entries that aren't countries HOT 6
- How to use intcal20 for calibration? HOT 2
- Parsers for Palmisano's datasets HOT 9
- remove TL dates from aDRAC parser
- Dev mode for URL downloading HOT 1
- Retain online lookup tables for backwards compatibility? HOT 4
- Simplify variable reference table
- wrong database encodings HOT 6
- Enable all fields to be returned with get_c14data() HOT 1
- Database versions as calendar dates or explicit version numbers
- fread configuration: colClasses = "character"
- List of datasets for c14bazAAR
- devtools::check() and devtools::check(vignettes = F) errors HOT 5
- get_neonet() HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from c14bazaar.