Git Product home page Git Product logo

Comments (9)

nevrome avatar nevrome commented on July 22, 2024

Good observation! Thank you!

It's not surprising given that the comparison algorithm is purposely simple. Maybe we could change the way EUROEVOL is loaded to add the hyphens? What do you think?

from c14bazaar.

nmueller18 avatar nmueller18 commented on July 22, 2024

Grrr. I had a look at the original EUROEVOL-dataset, and it is not consistent even there: Sometimes there are hyphens, sometimes there are spaces and sometimes neither. I think a parsing line (with catering for the three cases) should be entered here: c14age = .data[["C14Age"]],

from c14bazaar.

nmueller18 avatar nmueller18 commented on July 22, 2024

Are you sure that you have pushed your changes? I can see no differences.

from c14bazaar.

nevrome avatar nevrome commented on July 22, 2024

The changes are only in the specific branch for this issue.

You can install the version with them with devtools::install_github("ISAAKiel/c14bazAAR#61")

from c14bazaar.

nmueller18 avatar nmueller18 commented on July 22, 2024

Okay, I did not realize you created a new branch.

Indeed, there is an unexpected result: Some CALPAL-dates now have two hypens (e.g. UtC--10808). I suspect an ASCII-character that only looks like a hyphen.

from c14bazaar.

nevrome avatar nevrome commented on July 22, 2024

Thank you for testing!

The CalPal dates already had the double hyphens. I defined another case to solve this.

from c14bazaar.

nmueller18 avatar nmueller18 commented on July 22, 2024

Another case: Duplicate entries in the same database (RADON):

KN-1531
KN-I.531

from c14bazaar.

nevrome avatar nevrome commented on July 22, 2024

I don't think we can capture errors like this automatically. Or is there a systematic (!) difference that applies to many date pairs?

For individual errors: Please contact the authors of RADON.

from c14bazaar.

nmueller18 avatar nmueller18 commented on July 22, 2024

I think you can merge this branch. At least for me it works as expected and produced no detrimental results.

from c14bazaar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.