London dates not parsed correctly in bike_daily_trips() about bikedata HOT 4 CLOSED

Thanks for that - the whole package recently got restructured to do more intelligent auto-parsing of dates, but I'm now reliant on people directly finding these kinds of inconsistencies. It should be relatively straightforward to fix, so I'll get on to it asap.

from bikedata.

Actually seems okay. Can you make sure you have the latest version:

packageVersion("bikedata")
# [1] ‘0.2.0.100’

All dates for all systems should be DD/MM/YY or DD/MM/YYYY, or else other idosyncratic forms, but there are no systems which use MM/DD/YY(YY). Feel free to re-open is error recurs, but if so, could you please indicate which date ranges cause the errors (because London has thousands of files by now).

from bikedata.

oh sorry, just noticed you got the error from bike_daily_trips(), which I can indeed reproduce. And the pattern changes (in SQL date form) from 2016-31-12 (YYYY-DD-MM) to 2017-01-01 (YYYY-MM-DD).

from bikedata.

Sorry, misunderstood the problem myself there for a while. You were right: the dates for London weren't being processed properly at all. That PR should now fix it, and bike_daily_trips() should be free of NAs. Thanks for digging this up and helping fix this important 🐛 !

from bikedata.