Git Product home page Git Product logo

Comments (9)

AkihiroSuda avatar AkihiroSuda commented on July 17, 2024

Do you want to get this in v0.3.0 or can we defer it until QEMU upstream migrates to libslirp? (unlikely to happen until QEMU 4.1 https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg07003.html )

from slirp4netns.

giuseppe avatar giuseppe commented on July 17, 2024

this can happen after v0.3.0

from slirp4netns.

cyphar avatar cyphar commented on July 17, 2024

I was just about to post an issue about this. If we can use stock libslirp, from a packaging and "what is this software doing" perspective things will look much nicer. However we will need to push our patches upstream first.

I also want to look into getting LXC to be able to use slirp4netns as an alternative to their current set-uid approach (but I don't want to add a dependency to LXC which uses a forked libslirp that is statically built).

But yes, for packaging it would be easier if we wait until libslirp is actually used by qemu -- because then we can piggy-back off the official libslirp packages existing in distributions (rather than having to package it ourselves before they need it).

from slirp4netns.

AkihiroSuda avatar AkihiroSuda commented on July 17, 2024

I prefer to link libslirp statically for the time being so that we can experiment more optimizations (#16 #17) without dependency hell

from slirp4netns.

elmarco avatar elmarco commented on July 17, 2024

@AkihiroSuda couldn't #16 & #17 be opened in upstream libslirp instead?

Do you think we should hold back a libslirp release or is it good enough for slirp4netns in its current form?

from slirp4netns.

AkihiroSuda avatar AkihiroSuda commented on July 17, 2024

Yes, though I don't have bandwidth to look into #16 #17 deeper currently.

+1 on having releases ( https://gitlab.freedesktop.org/slirp/libslirp/issues/6 ) but not blocker for us.

from slirp4netns.

AkihiroSuda avatar AkihiroSuda commented on July 17, 2024

@giuseppe do you want to open PR for libslirp migration?

from slirp4netns.

AkihiroSuda avatar AkihiroSuda commented on July 17, 2024

opened #94 for vendoring freedesktop libslirp

from slirp4netns.

AkihiroSuda avatar AkihiroSuda commented on July 17, 2024

Merge request for moving slirp4netns patches to libslirp: https://gitlab.freedesktop.org/slirp/libslirp/merge_requests/8

@elmarco @giuseppe

from slirp4netns.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.