Limit concurrency per client about webwire-go HOT 2 CLOSED

It does make sense, but I'm not yet sure, how to implement it, because there's three options:

• Setting the limit globally at server initialization affecting all clients.
• Setting the limit individually for each client during connection establishment.
• Setting a default global limit at server intialization, which is overridable by individual limits set during connection establishment.

The second option seems to be the most flexible one, this might be done in the BeforeUpgrade hook like so:

func (srv *ServerImplementation) BeforeUpgrade(
  resp http.ResponseWriter,
  req *http.Request,
) bool, uint {
  // accept connection, limit concurrency to max 5
  return true, 5
}

Returning 0 would mean unlimited concurrency for this individual client.

from webwire-go.

The concurrency limit is now set in the BeforeUpgrade hook this way:

func (srv *ServerImpl) BeforeUpgrade(
	resp http.ResponseWriter,
	req *http.Request,
) wwr.ConnectionOptions {
	// return wwr.AcceptConnection(wwr.UnlimitedConcurrency)
	return wwr.AcceptConnection(10) // max 10 concurrent handlers
}

The server option MaxConcurrentHandlers is no longer available. If you still want to limit the total number of concurrent handlers for the entire server you'll need to set appropriate per-client limits (say 10 for a total 10.000 maximum concurently executed handlers for 1.000 concurrent clients) and limit the number of clients by atomically counting the number of connected clients and rejecting or redirecting incoming connections in the BeforeUpgrade hook when the limit is reached.

from webwire-go.