Typing for I18NextFormatPipe only takes string? about angular-i18next HOT 11 CLOSED

@Romanchuk any thoughts on this? I think this will block people.

from angular-i18next.

I see that you copied their type, I think they were wrong too.

DefinitelyTyped/DefinitelyTyped#25181

from angular-i18next.

@httpete Sorry, had no time to answer.
Yes, i use string type for value derrived from these types. You are right, value can be an any type.
There would no problem to fix it for me, because i call format throught call function that is not typed.
I'm going to update package in a week (with this fix and i18next v11 support)

from angular-i18next.

ok I will look for it. Thanks - I bet you can limit to Date, String, or Int. I can't imagine formatting any other data type.

from angular-i18next.

@httpete version 3.4.1 released. An any type allowed as value.

from angular-i18next.

To be more correct, I think restricting it to one of the few would be better:

value: string | Date | Int

from angular-i18next.

@httpete i18next has no restrictions on what type it can format. It can be number, string, date or an any complex object, depending of you system requirements.
The main reason why "value" has "any" type - i don't want to set artificial limitations on top of i18next. If i18next has posibillity to format any type, angular-i18next must have it too.

from angular-i18next.

I don't see this in 3.4.1.

import { PipeTransform } from '@angular/core';
import { ITranslationService } from './ITranslationService';
export declare class I18NextFormatPipe implements PipeTransform {
    private translateI18Next;
    constructor(translateI18Next: ITranslationService);
    transform(value: string, options: Object | string): string;
}

from angular-i18next.

@httpete my fault, i will fix it today

from angular-i18next.

@httpete finally, done)

from angular-i18next.

thanks Romanchuk! Just for anyone else watching, I was trying to utilize the angularCompilerOption:

    "fullTemplateTypeCheck": true,

which was failing on i18next format pipes (correctly since it was set as string) and after this update, it's perfect. Thank you!

from angular-i18next.