Git Product home page Git Product logo

Comments (6)

roman-right avatar roman-right commented on May 17, 2024

Hi @paul-nameless ,

_id field itself is reserved by MongoDB to be used as a primary key. Typically it uses ObjectId for this. Correct me, if I'm wrong. Do you mean it would be useful to be able to use other data types for this primary key, right? Or are you talking about another use case?

from beanie.

paul-nameless avatar paul-nameless commented on May 17, 2024

You are right, it's reserved and required https://docs.mongodb.com/manual/reference/bson-types/#objectid

_id is often used as non ObjectId type as a "free" unique index, which doesn't require additional index setup, disk space and memory. This is quite crucial for big collections.

So that would be great to make it more flexible.
I find beanie as the best and simple async orm for Mongo right now.

from beanie.

roman-right avatar roman-right commented on May 17, 2024

First of all, thank you :-) I'm happy that it is useful.

I see. Yes, I do agree, it would be better to have this more flexible. This is linked with some internal logic and, unfortunately, it is impossible to replace it on the move fast. But I will put this improvement at the top of the backlog and will pick it up after the current major update.

Thank you.

from beanie.

paul-nameless avatar paul-nameless commented on May 17, 2024

Basically, something like this let autogenerate _id if it's not set and use the given value otherwise.

paul-nameless@7d4d78c

That's just draft, if you don't see any issues and happy with this, I could continue working on it.

from beanie.

roman-right avatar roman-right commented on May 17, 2024

Yes, this will partially work

The idea of this check is to understand if the document was already inserted or not. Bc if it was inserted, it will not be inserted again - the driver will just ignore the operation. It will not update anything and will not even warn, as I remember, about the double insert attempt. This can confuse. That's why there are two methods create to insert the document and replace for the full update.

There are some ways, how to solve this using custom id types:

  • A document can have an additional flag, like _is_inserted to manage these states. It must be hidden (protected). It will not protect from all the possible collisions, but most of them will be avoided.
  • create() method can check if the document with this id was already inserted into the database. It will solve all the collisions, but also it will increase the number of calls.
  • Probably smth else, I didn't think well about this.

I prefer the first one for now.

So yes, if you want to develop this feature - you are welcome for sure :-)
If you want to chat about any details, you can do it in discord. The link is in the project readme

from beanie.

roman-right avatar roman-right commented on May 17, 2024

Hi @paul-nameless ,

Thanks for your idea. It is implemented now. To set custom id, follow the example:

from uuid import UUID, uuid4

from pydantic import Field

from beanie import Document


class Product(Document):
    id: UUID = Field(default_factory=uuid4)
    name: str
    description: str

Be aware, that you should not set up an id alias now, it is configured globally

from beanie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.