Class methods are incorrectly renamed about rollup HOT 4 CLOSED

Is this a good place for a contributor to start? It seems like a good excuse to dig into the codebase.

from rollup.

Would be an excellent place, and you'd be extremely welcome 😄

It think it's just a matter of having a similar check to this one further down, next to these ones.

from rollup.

I can't reproduce the original problem. Using this code as foo.js:

import { parse } from 'acorn';

class Module {
  parse () {
    // ...
  }
}

export default parse;

When I run rollup -i foo.js -f cjs -e acorn I get this output:

'use strict';

var acorn = require('acorn');

class Module {
  parse () {
    // ...
  }
}

var foo = null.parse;

module.exports = foo;

So there's clearly a problem, as null should be acorn, but I can't get it to rewrite parse() { as acorn.parse() {.

from rollup.

Yeah, turned out there were a couple of things going on here, fixed in 0.11.3. The method name got rewritten if the function was used in the module in question; the null.parse thing was happening because module.getCanonicalName was called before external modules were assigned names - just needed to change the order.

from rollup.