Comments (6)
Thanks. No need for a more isolated test, I reckon this is small enough to work with - will look into it as soon as I get a chance. Not immediately sure what's causing it but am sure it's fixable (he said confidently...)
from rollup.
@mbostock Turns out I'm struggling to reproduce this - all the d3-shape tests are passing for me, and the statement ordering looks to be correct. Has anything changed since this issue was opened?
from rollup.
Yeah, there’s a workaround I’ve been using.
I’ll try to pare down a standalone test case.
from rollup.
Here ya go:
https://gist.github.com/mbostock/bc1ffc78c3f933eff312
Note that if you reverse the order of statements in index.js, the test passes!
from rollup.
Ah, I see what's going on here. The (new Foo)
line causes the Foo
definition to be included, which means also including Foo.prototype.test = ...
and (because rollup can't know that Object.create
doesn't modify Foo.prototype
) Bar.prototype = Object.create(Foo.prototype)
. So the second line, which causes the Bar
declaration to be included, doesn't include the Bar.prototype =
statement because it's already included.
Not immediately sure what a general solution looks like (the last time I tried to naively sort statements according to their original order, it ended badly), but I'll try a few things. Suggestions welcome!
from rollup.
Fixed in 0.9.0 - have confirmed all the d3-shape tests now pass without the workaround
from rollup.
Related Issues (20)
- 4.16.4 throws Cannot find module @rollup/rollup-darwin-arm64 error MODULE_NOT_FOUND in Ember Embroider app HOT 4
- Node 16 not supported any longer, can't run more modern Node's either HOT 5
- Provide a mechanism to build manualChunks which can be reused across multiple outputs.
- Upgrade from vite 4 to vite 5 crashes in rollup with maximum call stack exceeded HOT 2
- function parameter tracking does not handle spread syntax in arguments correctly HOT 3
- top level return for IIFEs HOT 2
- Function body being mistakenly optimized away HOT 3
- After Babel starts runtime and rolls up preserveModules=true, it will result in an extra layer of output structure HOT 5
- I have a query about the rollup build process with export classes as opposed to export functions HOT 3
- Unknown Fatal Error if code is not an int
- Error: 'default' is not exported by node_modules/interactjs/dist/interact.min.js,
- Don't create dynamic import objects when never used
- Provide original name of exports in output bundle
- Node.JS 22.2.0 rollup 4.18.0 hits `[!] SyntaxError: Unexpected identifier 'assert'` error HOT 1
- React component wont render
- How to configure the .scss file under the style folder to generate a .css file in dist/style/ after building?
- Does not support BSD, not sure why, but it should be easy to port. HOT 2
- Declaring `sideEffects` causes Rollup to drop code with side effects HOT 2
- How to named export from CommonJS module with rollup?
- Packaging vue components, it seems that typescript code is not recognized
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rollup.