Comments (2)
Ideally, best resolution would be proper implementation in rbx_dom_lua, but until that happens, it would at least be nice to not have Rojo entirely crash when trying to import a model just because of one unsupported property.
What actually needs to happen is for us to distinguish between unknown and unimplemented datatypes in rbx_dom_lua, ha ha. This is my fault because I added the error without thinking too much about what the consequence was for Rojo; my intention was to communicate that the data type didn't have a codec, but that's not a good way to do so. We should probably not be passing unscriptable properties to Rojo's plugin, but that's not an excuse and going forward I'll do a better job.
Ken has fixed it in rbx_dom_lua, and it'll make its way over here soon. We'll make a new release candidate shortly after it does.
And unrelated, but I am somewhat curious on what this property even is? As I mentioned, documentation seems to be entirely nonexistent, and it doesn't seem to be set to anything besides 0. I'd love to hear a surface-level explanation if it's ever documented.
We know relatively little about it, but from what I was told, it's eventually going to be for permissions for things like plugins and free models to prevent abusive behavior. I doubt Roblox will ever release official documentation but we'll try to document it eventually once we have some more ideas as to what the permissions are (right now they're zeroed out by Studio, so they don't do anything).
from rojo.
We should probably not be passing unscriptable properties to Rojo's plugin, but that's not an excuse and going forward I'll do a better job.
I don't think scriptability has much to do with this. The stack trace shows that the cause of this this error was the patch visualizer attempting to decode a SecurityCapabilities
in the initial patch. While not sending the property at all would have prevented this from happening, Rojo server has always sent unscriptable properties, and I don't think it's a bad thing... it allows the plugin to know whether it is unable to set a desired property, and to surface this information to the user.
[...] communicate that the data type didn't have a codec
I think absence of a coder/decoder is enough here, maybe we could just add another error variant to decodeValue
for this case?
from rojo.
Related Issues (20)
- rojo build doesn't work for Int32 and Int64 HOT 1
- Ref property application can fail when pointed-to instances don't yet exist
- Updates for Ref properties specified with attributes are always `null` in `/api/subscribe` responses HOT 2
- Two-Way-Sync crashes rojo instance when editing under a protected drive
- Upload.ashx endpoint has been disabled for places, we should raise an error when trying with `rojo upload`
- Emit helpful errors when file system access fails rather than just calling `unwrap`.
- Two-Way Sync Deletes Changes and Crashes After
- The system cannot find the file specified. (os error 2) (roshade) HOT 1
- Add support for Assigning Enum as Attribute through init.meta.json HOT 1
- Parent and Child Folder: Cannot add an instance from a patch that has no parent. HOT 3
- Cannot select Studio Rojo plugin error text to Copy Paste HOT 2
- Is it possible to edit the properties of a value in studio and have the changes go into the Rojo UI? HOT 1
- SurfaceAppearance.Color might be set to (0,0,0) by default instead of (1,1,1) causing black SurfaceAppearances HOT 3
- Table diffing has unreadable text color in dark theme
- Rojo v7.4.2 corrupts refs, meshes & part positions HOT 24
- Wally package causes folders in rbxl/rbxm files built by Rojo to have Archivable set to false HOT 2
- Add a place ID blacklist to project config HOT 3
- Suggestions to improve fmt-project HOT 1
- init.json files should change the parent directory to be a script HOT 1
- Rojo crashes when updating npm package HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rojo.