godef not work in go mod about godef HOT 4 CLOSED

Because github.com/micro/go-micro is not managed by go mod, so when godef search in go-micro, it search in GOPATH (go env GOPATH).

So you can go get in GOPATH: go get github.com/micro/go-micro, and it fixed.

No, is not good idea. The depend package will download in GOPATH/pkg when I use go mod,So why do I download the package in GOPATH/src?

from godef.

Because github.com/micro/go-micro is not managed by go mod, so when godef search in go-micro, it search in GOPATH (go env GOPATH).

So you can go get in GOPATH: go get github.com/micro/go-micro, and it fixed.

from godef.

the DefaultImportPathToName will search one pkg in the srcDir(context where uses this pkg), to solve this, you can try to search in the rootDir(where to begin search) when DefaultImportPathToName fail.

func DefaultImportPathToName(path, srcDir string) (string, error) {
	if path == "C" {
		return "C", nil
	}
	pkg, err := build.Default.Import(path, srcDir, 0)
	return pkg.Name, err
}

func DefaultImporter(path string, srcDir string) *ast.Package {
        ...
        pkgs, err := parser.ParseDir(FileSet, bpkg.Dir, shouldInclude, 0, DefaultImportPathToName)
}

So, in DefaultImporter(), you can add a tryable ImportPathToName:

type TryableImportPathToName string

func (rootDir TryableImportPathToName) ImportPathToName(path, srcDir string) (string, error) {
	pkgName, err := DefaultImportPathToName(path, srcDir)
	if err == nil || srcDir == string(rootDir) {
		return pkgName, err
	}

	return DefaultImportPathToName(path, string(rootDir))
}

func DefaultImporter(path string, srcDir string) *ast.Package {
        ...
	pkgs, err := parser.ParseDir(FileSet, bpkg.Dir, shouldInclude, 0, TryableImportPathToName(srcDir).ImportPathToName)
}

from godef.

anyone looking forward to solve this with a PR ?

from godef.