Public access ot LocalFreeGuard::new or LocalFree about winsafe HOT 2 CLOSED

WinSafe is designed to be interoperable with other libraries, so it has many escape hatches, like Handle::ptr and LocalFreeGuard::new. Indeed, I wrote that they are not meant to be used externally, but maybe it's an overconservative comment, because they can – that's why they're all pub. They must be unsafe, however, since they can easily trigger UB.

In your specific case, you can construct the HLOCAL and store the guard like this:

use winsafe::{self as w, prelude::*};

let pp: *mut std::ffi::c_void; // initialized somewhere

let my_handle = unsafe { w::HLOCAL::from_ptr(pp) };
let my_guard = unsafe { w::guard::LocalFreeGuard::new(my_handle) };

Or, if you just need to call LocalFree immediately:

use winsafe::{self as w, prelude::*};

let pp: *mut std::ffi::c_void; // initialized somewhere

let _ = unsafe { w::guard::LocalFreeGuard::new(w::HLOCAL::from_ptr(pp)) };

I will review the docs, and make it explicit that you can use those stuff to interop with other libraries.

Is this OK?

from winsafe.

Yeah, it’s just the comment that I was concerned about. I’m already doing exactly what you suggested in your first example. I agree that new should be unsafe. Thanks!

from winsafe.