Wrong GetAsyncKeyState return type. about winsafe HOT 4 CLOSED

Yep, that's it.

Can you check now?

from winsafe.

It's working :) thank you, this crate saves so much pain.

from winsafe.

GetAsyncKeyState returns multiple key states: hold, was pressed after previous call to GetAsyncKeyState ("However, you should not rely on this last behavior" so I don't know if this is actually important in "safe" crate

I'd say this is important not only in the context of a safe crate: even in C++ code we shouldn't rely on that.

then most significant bit should be checked instead rather than comparing it with 0

You are correct. I fixed the implementation with example given in the documentation itself.

from winsafe.

I think it should be & 0x8000 != 0 or just < 0 (since its the sign bit), because with current version it will return true even if key is not held anymore (but was held in previous GetAsyncKeyState call):

use std::thread::sleep;
use std::time::Duration;
use winapi::um::winuser::{GetAsyncKeyState, VK_CONTROL};

fn main() {
    println!("Hello, world!");
    loop {
        sleep(Duration::from_secs(5));
        println!("state: {:?}", unsafe { GetAsyncKeyState(VK_CONTROL) & 0x01 });
    }
}

Documentation example shows key press usage, it is kinda different - it reacts for key down and up.

from winsafe.