LoggerFactory.GetInstance does not return a new instance of the logger about rocklib.logging HOT 4 CLOSED

It is a factory so it is supposed to only create the instance once per type/category creation if I remember correctly. Creating the logger is expensive and isn't supposed to be recreated with each and every call.

from rocklib.logging.

That's all fine and good, but that call doesn't check that the instance has been disposed of if/when someone does use DI as something other than Singleton.

Alternatively, the decision to use scoped over a singleton or visa-versa should be left up to the developer (recommended usage can be placed in the documentation explaining why it may be a bad idea to not use a singleton, as it stands, there is no explanation that a new version of the logging class will be created when an existing version is disposed of)

from rocklib.logging.

Indeed it does not dispose of the logger instances in 1.x. We've addressed the issue in the 2.0 version, which has pre-releases published to nuget right now (we anticipate publishing the release version next week). Instead of LoggerFactory.GetInstance, version 2.0 has two methods: LoggerFactory.Create and LoggerFactory.GetCached. This is exactly your suggestion. 😄

from rocklib.logging.

that it is, thanks for the update!

from rocklib.logging.