Git Product home page Git Product logo

Comments (5)

timkinnane avatar timkinnane commented on June 12, 2024

Can it access the main process.env e.g. for Heroku environments, there might be a lot of useful stuff in there. Another key one would be local/dev/staging/live environment switches.

from rocket.chat.apps-engine.

timkinnane avatar timkinnane commented on June 12, 2024

Making the list of enabled Rocketlets available as an env var would also be handy for any tricky workarounds once the inevitable conflicts between extensions start to surface.

from rocket.chat.apps-engine.

graywolf336 avatar graywolf336 commented on June 12, 2024

No, the Rocketlets are going to be in a restricted environment which only has access to provided variables and global properties. Honestly, I'm debating whether or not to even allow environmental variables 🤔

from rocket.chat.apps-engine.

timkinnane avatar timkinnane commented on June 12, 2024

Well as long as they can access mongo and manage their own settings, I think that would cover most use cases where the Rocketlet's logic might need some wider context about the state of the RC instance. I'm sure there'll be unforeseen uses but its not worth trying to predict and over-engineer, just have to deal with it as they evolve.

Maybe a permissions layer (which could be quite simple for now) should be considered for this type of thing, to keep instance owners informed of security risks when installing Rocketlets, then we don't have to be overly protective and limiting. Similar to permissions for users, but implemented like adding a facebook app, e.g.

This Rockelet can

  • modify user roles
  • modify messages

The above could have some correlation to the internal API endpoints used in the Rocketlet source.

I've probably gone off-topic for this issue. 🤷‍♂️

from rocket.chat.apps-engine.

graywolf336 avatar graywolf336 commented on June 12, 2024

Closing as so far the allowed ones are: 'NODE_ENV', 'ROOT_URL', 'INSTANCE_IP'

from rocket.chat.apps-engine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.