Comments (2)
Hi, @meomay503!
Could you specify the OS in which you've had this issue with symbolic links? Its File System must be compatible with symbolic links.
We are working on this issue and we may give you a feedback about it soon! 😀
from rocket.chat.apps-compiler.
Hi @matheusbsilva137, I've got this issue on both Ubuntu 18.04 (WSL) and Windows.
After debugging I found that the bug is from the @rocket.chat/apps-compiler
.
https://github.com/RocketChat/Rocket.Chat.Apps-compiler/blob/master/src/compiler/getAppSource.ts#L24
The point is you guys are checking dirent.isDirectory()
but dirent
can be symlink
. Reading symlink
to directories can cause the above bug.
I suggest using the find real path function of NodeJs and do the check again on the real path. :D
from rocket.chat.apps-compiler.
Related Issues (12)
- The fs module exposes "promisified" versions of its methods via fs.promises - no need to do it manually anymore :)
- Maybe if we used the [glob package](https://www.npmjs.com/package/glob) we could even ignore files with `.gitignore` 🤔
- Maybe if we used the [glob package](https://www.npmjs.com/package/glob) we could even ignore files with `.gitignore` 🤔
- We haven't planned on allowing apps to use these packages in the run-time, and haven't measured the possible impacts/vulnerabilities it can cause. Are we required to do this here?
- Diagnostics Aren't Correct HOT 1
- App abstract class inheritance checking failed for multilevel inheritance HOT 1
- Exclude tests from compiler HOT 1
- Fix in 0.3.1 causes import bug with module which has only 1 export HOT 1
- [Question] Seems we cannot use our own tsconfig file anymore?
- [Error][Windows] Import files cause errors
- Referenced file "SettingsApi.ts" causes VERY UNEXPECTED ERROR HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rocket.chat.apps-compiler.