Comments (16)
Have no permissions to add a label, also I don't see the board.
Not good. I've selected a different permission level (triage -> write) for the go team, could you check now?
from roc-go.
.pc generation & installation landed in develop branch. scons install
will now install roc.pc
.
cc @fusuiyi123
from roc-go.
cool, then I'll test it locally with develop, push to a branch and create a pr later when the changes will be available on master (they are still not there as of now)
from roc-go.
I've updated roc-streaming/roc-toolkit#271
from roc-go.
Can you add a label "blocked" or "camping"? Or can you give me the permissions to add tags? :3
from roc-go.
Hm, I don't see such a permission in settings.
Probably it's better to user projects for that? Like we do it in core: https://github.com/roc-project/roc/projects/2
I've enabled projects for the repo, you can try it (do you have permissions?). Or I can just create the label, I'm OK with that too.
from roc-go.
from roc-go.
works! thanks
from roc-go.
from roc-go.
now that I've looked into it, is this feature relevant? The only place where we use the C includes are comments like
/*
#include <roc/address.h>
*/
import "C"
which work regardless if one uses pkg-config or just installed them with their distribution's package manager.
from roc-go.
If the user installed roc into a prefix which is not in default include or library search path list, compilation will fail. pkg-config will solve this issue.
A real-world examples. When you're using SoX library you should write:
#include <sox.h>
On most distros, sox.h is located at /usr/include/sox.h and include works without any pkg-config.
However, on some CentOS version, for some reason maintainers decided to install that file at /usr/include/sox/sox.h. On those CentOS systems pkg-config for SoX returns -I/usr/include/sox
. If you're using pkg-config, everything works, but without it your include fails.
So yes, we still need pkg-config, though it's not critical.
Note that pkg-config generation is currently available only in develop, while bindings are using master.
from roc-go.
Example of using pkg-config with cgo: https://github.com/aam335/speexdsp/blob/master/speexdsp.go#L4
from roc-go.
We'll also need to migrate bindings to new api from 0.2.
from roc-go.
I guess we need a separate issue and branch for that.
from roc-go.
@gavv did you release 0.2 already? cannot find it anywhere
from roc-go.
@Asalle Hi, no, 0.2 isn't released yet. It's still in the develop
branch. The API of 0.2 is mostly stabilized; it will be changed a bit before final release, but I expect only minor changes. So I think we can start migration of bindings to 0.2, maybe in a separate branch (maybe also call it develop
for convenience).
from roc-go.
Related Issues (20)
- Add debug logging HOT 5
- Add version checking HOT 5
- Use time.Duration for time intervals HOT 4
- Use stringer for all enums HOT 3
- Use time.Time for LogMessage.Time HOT 2
- Add CI step that checks that gofmt was called HOT 1
- Add command-line flag to enable logs in tests HOT 2
- Optimize how blocking I/O interacts with Go scheduler
- Improve acceptance criteria of end-to-end test
- Add end-to-end test without FEC
- Add end-to-end test with resampler
- Add end-to-end test with internal clock
- Add end-to-end tests with multiple senders and receivers
- Create python script for making release
- Implement "-f" option in tag.py script HOT 1
- Use latest go version on CI
- Update to 0.3 HOT 1
- Add bindings for roc_sender_encoder and roc_sender_decoder
- Add bindings for metrics functions
- macOS tests fail from time to time
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roc-go.