Git Product home page Git Product logo

Comments (10)

robstewart57 avatar robstewart57 commented on July 20, 2024

HI @joshsh I've asked the hgal maintainer, who'd like to keep the GPL v2 license for that library.

One option therefore could be for me to create a GitHub Gist, copy/pasting the isGraphIsomorphic function there with the GitHub page pointing to it if people want to compute RDF graph isomorphism using hgal. Then, remove the isGraphIsomorphic from the rdf4h library and the testsuite, along with the hgal dependency.

from rdf4h.

joshsh avatar joshsh commented on July 20, 2024

Thanks for checking, @robstewart57 . Yes, if you are willing to downgrade that function to a Gist and remove the dependency, that would allow me (and potentially others with license constraints) to proceed.

from rdf4h.

robstewart57 avatar robstewart57 commented on July 20, 2024

@joshsh OK, I've moved the isGraphIsomorphic function out to a gist, and I've removed hgal from the cabal file.

This is reflected in release 4.0.2.

Removing isGraphIsomorphic in the unit tests, instead relying on isIsomorphic, identified a small handful of Turtle and XML parser bugs in rdf4h, and I will fix these when I return in a couple of months.

from rdf4h.

joshsh avatar joshsh commented on July 20, 2024

I see the compile errors. Separate issue but do you know if there is a way I can ignore the errors when depending on rdf4h via Stack? Otherwise, I will still have to come up with an rdf4h alternative for our initial release.

from rdf4h.

joshsh avatar joshsh commented on July 20, 2024

For now, I have copied the sources I need into Dragon, with appropriate license information. When the build issues are resolved, I will remove these sources and restore the rdf4h dependency. Thanks.

from rdf4h.

robstewart57 avatar robstewart57 commented on July 20, 2024

@joshsh Compiler errors? There aren't any compiler errors in version 4.0.2 or git HEAD, as far as I'm aware?

What I referred to with:

identified a small handful of Turtle and XML parser bugs in rdf4h

Is some unit tests fail with stack test. The stack build and stack install commands should compile rdf4h fine.

Let me know if this isn't the case for you.

from rdf4h.

joshsh avatar joshsh commented on July 20, 2024

Now that you mention it, yes rdf4h 4.0.2 builds from source without any issues. The errors I encountered were due to dependency conflicts, and I was able to resolve them. I will issue a PR to remove hgal from rdf4h's stack.yaml, as FOSSA may notice it and flag it as a GPL dependency otherwise.

from rdf4h.

robstewart57 avatar robstewart57 commented on July 20, 2024

from rdf4h.

joshsh avatar joshsh commented on July 20, 2024

Actually, FOSSA does not flag this. I guess it only has access to the .cabal file. There is no longer anything standing in the way of a release of Dragon with rdf4h. Thanks!

from rdf4h.

robstewart57 avatar robstewart57 commented on July 20, 2024

@joshsh I've removed it from stack.yaml anyway, since it is no longer needed.

46cdc7e

from rdf4h.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.