Add functionality to click on menu item text when number of menu items is more than six about robotium HOT 5 CLOSED

From [email protected] on October 15, 2010 15:00:51

Hi, this functionality already exists:
clickOnMenuItem(String text, boolean subMenu)

Status: Invalid

from robotium.

From [email protected] on October 15, 2010 15:13:47

Sorry, didn't realize the method clickOnMenuItem(String text, boolean subMenu) already exists.

But as a usability thing why not just keep one method as clickOnMenuItem(String text)
and let it take care of more menu options rather than overloading. Is it because of backward compatibility.

from robotium.

From [email protected] on October 15, 2010 19:39:20

It is because of backward compability. The clickOnMenuItem(String text, boolean subMenu) was first implemented in 1.7.0.

from robotium.

From [email protected] on October 15, 2010 19:45:10

Also becuase "More" is not always called More (localization issues) so basically the only way to know that the button is actually More is if there are 6 text fields in the menu. That however could mean that the 6th text field is not a more and then this feature would fail. That is why the subMenu parameter is needed.

from robotium.

From [email protected] on October 15, 2010 20:06:06

Thanks for the explanation, I have just one more comment/clarification:
the way code for clickOnMenuItem(String text, boolean subMenu) is written, it first checks if there is textMore on screen, if it exists then it clicks it otherwise it just directly clicks on text. So the extra param can be removed and clickOnMenuItem always do this
if(textMore != null)
clickOnScreen(textMore);

clickOnText(text, false, 1, false);

from robotium.