Git Product home page Git Product logo

Comments (9)

jinatonic avatar jinatonic commented on July 17, 2024 1

so after looking it ended up still being the android touch system dispatching multiple events despite your finger being completely still as I can't reproduce the issue in the ticker library or on android emulator scrubbing the GPRO graph (but I can repro it on my phone). I'll do the fix in the robinhood app.

from ticker.

jinatonic avatar jinatonic commented on July 17, 2024 1

The issue is fixed in robinhood and will be included in the next app update.

from ticker.

jinatonic avatar jinatonic commented on July 17, 2024

Hello,

Thanks for filing the issue. This is actually not a problem with ticker (well, I guess it technically is), but it's because on the robinhood app there are simply too many data points on the 1Y graph. So when you hold down your finger at one point, the data under your finger continuously changes among 2 or 3 values which means ticker tries to animate from X to A then B then A then B then A etc. and never finishes the animation.

But yeah, we should fix that issue on robinhood side to buffer input events once you start scrubbing the graph. I'll try to get it in for a near future release.

from ticker.

UnsungHero97 avatar UnsungHero97 commented on July 17, 2024

The issue is reproducible on the 1D and 1M graphs as well.

I just checked the Workday stock WDAY for today, and it drops below $100 around 10:10am, as well as around 12:50pm. The issue is reproducible at those dips in the 1D graph. The same happens when looking at the 1M graph for GoPro GPRO.

Let me know if you need a screen recording to demonstrate.

from ticker.

jinatonic avatar jinatonic commented on July 17, 2024

oh interesting, you are right, ill look into this.

from ticker.

UnsungHero97 avatar UnsungHero97 commented on July 17, 2024

Thanks!

from ticker.

UnsungHero97 avatar UnsungHero97 commented on July 17, 2024

Sweet! Thanks for the quick turnaround on this! Can't wait for the next app update to come through!

from ticker.

danh32 avatar danh32 commented on July 17, 2024

I wonder if it's worth adding a safeguard in ticker as well? Like no-op the setText() call if we're already animating to the same value?

from ticker.

jinatonic avatar jinatonic commented on July 17, 2024

haha good point. this was actually supported by the library but one of my refactors on how tickercolumn works must have broke it.

from ticker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.