Performance issue with binding event directly to scroll about scroll-depth HOT 7 CLOSED

Hey,

Can you provide a URL to your test code? Events should only fire at the scroll points. For the percentage tracking there's a maximum of 10 events that can fire per page. Also I haven't seen any problems with multiple events firing for the same event.

All that aside, adding throttling is probably a good idea anyway. :)

Thanks
Rob

from scroll-depth.

@Weizhen
Added throttling on a dev branch: 5a0ec29

Look good? Will do some more testing tomorrow.

from scroll-depth.

Hi Rob, It looks great! Thanks to _JS :)

I have added a few features that were included in my project, we have a configurable GUI input, so several more options were defined like dynamic milestone, and custom throttle delay.

I have commit the change (I think it will work...), let me know if you want to test it, my pleasure to be part of this!

/Weizhen

from scroll-depth.

Weizhen@e6af569

my fork

from scroll-depth.

Thanks. Were you finding cases where the events fired twice for the same scroll mark? I haven't encountered that. The cache array should prevent that, no?

from scroll-depth.

merged throttling into master 5a0ec29

from scroll-depth.

Great! I probably got old version of code, i pulled it from one of our customers tag manager, where i saw scrolling event for same percentage triggers multiple times. Ignore it if it is not the case.

from scroll-depth.