What is the desired behavior of preventRepeat? about keyboardjs HOT 6 CLOSED

This should be fixed now. I added a test case as well. Let me know if things are working for you now. If not please follow up and I'll have another look 👍

from keyboardjs.

@ianshade this seems to be a bug, you can get the behavior you want by passing an empty releaseHandler to bind()

keyboardJS.bind('escape', function(e) {
	e.preventRepeat();
	console.log("pressed escape");
}, function(e) {
	
});

from keyboardjs.

@boldenburg Wouldn't it be better not to pass unnecessary releaseHandler?

from keyboardjs.

Unfortunately it's the nature of bugs to force us into what appears to be unnecessary behavior.

from keyboardjs.

A bug in same theme: the preventRepeatByDefault parameter seems to block the press callback altogether, so manually calling preventRepeat() and supplying a no-op release handler is the only way to go.

from keyboardjs.

Hmm, this is a crappy bug. Looking into it.

from keyboardjs.