Classes added to the combobox are removed on select about dropkick HOT 4 CLOSED

I'm going to close this as I feel you could typically solve this by just using a different selector to target Dropkick specifically.

Where you might currently have something like this:

.input:focus {
  /* ... */
}

You could add a similar class to Dropkick and target it this way:

.input:focus,
.dk-input .dk-selected:focus {
  /* ... */
}

Of course, this might not always be so easy if you're using a CSS framework. In either case, I don't feel like this is a bug as adding classes to the generated markup after initialization was never intended. If you must, I think reattaching it in the change handler as you did should work fine.

from dropkick.

Dropkick allows you to add classes to the select and the individual options to allow for some extra customizations.

Example:
http://jsbin.com/bivudi/edit?html,css,js,output

The reason that line removes the old classes is so previous classes added from other options aren't persisted when the selected option changes.

from dropkick.

Ah, I missed that in the docs. Thanks @wwilsman

from dropkick.

Think I have closed this too soon. On my bin, the input class is attached to the dk-selected div.
On yours, it's attached to the root element (dk-select). It cause some buggy styling in my case as I have some :focuson .input.

One solution could be to pass the option.className to the root element instead (so we can also always reattach the select className to preserve current behavior), but this is a breaking change.

For now, I simply reattach the class on the change handler, a bit ugly but it does the job.

Reopening in case you want to chime in, feel free to close if you don't think there's need for change.

from dropkick.