Git Product home page Git Product logo

Comments (7)

dvargas92495 avatar dvargas92495 commented on August 9, 2024 1

Yea I 100% agree. In fact most of the other integrations/RoamJS services have already moved to using local storage, just haven't gotten around to doing the same for otter yet, since it's a somewhat unique integration (the only one that asks for a password)

from otter.

Stvad avatar Stvad commented on August 9, 2024

poke on this, as I think it's a huge red flag on using this =.

also, another random thought on improving this is to store the password in an encrypted fashion (and retrieve decryption key from calling roamjs api, as we must call it anyway). variations possible on:

  • having one rotating key for everything (only somewhat helpful, but adds a layer of protection from casual read & dump of localstorage. does not protect from a targeted attack)
  • having user specific keys (better, but requires more infrastructure work on your side, and maybe at that point you might as-well store password on the server side)

from otter.

dvargas92495 avatar dvargas92495 commented on August 9, 2024

Not sure storing a decryption key with RoamJS necessarily increases security.

With the password in local storage, only one actor has access:

  • those with access to the user's browser

With a decryption key stored in RoamJS, now there are two:

  • those with access to the user's browser
  • those with access to RoamJS

from otter.

Stvad avatar Stvad commented on August 9, 2024

The scheme I was proposing is: password stored in encrypted form in local storage, and decrypted on-demand by the backend when it's used (and the encryption key is stored on the backend).

In which case ideally the only time password exists in cleartext is on backend at execution time (which is the case right now as-well).

from otter.

Stvad avatar Stvad commented on August 9, 2024

Actually on reflection I think this provides a better security then I thought, as you don't actually need to store/or retrieve password in cleartext locally at all. So after set up you can't get back the password out of the browser (though you'd still be able to use the encrypted version of it with roamjs if the decryption key is not personalized)

from otter.

dvargas92495 avatar dvargas92495 commented on August 9, 2024

Ok yea I see how we could do this. Every RoamJS user has a personal API token that we may be able to use as the decryption key

from otter.

Stvad avatar Stvad commented on August 9, 2024

Thanks! will look over implementation in a bit 🙂

from otter.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.