Comments (10)
rndusr
commented on September 15, 2024
Shouldn't it be `python ./setup.py install --root=`?
Otherwise, no idea, sorry. I know practically nothing about python packaging.
If it works, why don't you use pip?
from torf.
doronbehar
commented on September 15, 2024
I'm trying to follow packaging guidelines outlined here.
from torf.
rndusr
commented on September 15, 2024
It looks like it depends on the current `umask`.
$ umask 000
$ python3 setup.py build
[...]
$ python3 setup.py install --root="./test" --optimize=1 --skip-build
[...]
$ ls -la test/usr/local/lib/python3.6/dist-packages/torf
total 68K
drwxrwxrwx 3 ich ich 4.0K May 4 12:24 ./
drwxrwxrwx 4 ich ich 4.0K May 4 12:24 ../
-rw-rw-rw- 1 ich ich 3.3K Jan 13 17:18 _errors.py
-rw-rw-rw- 1 ich ich 1.2K Jan 2 17:42 __init__.py
drwxrwxrwx 2 ich ich 4.0K May 4 12:24 __pycache__/
-rw-rw-rw- 1 ich ich 34K Apr 7 19:33 _torrent.py
-rw-rw-rw- 1 ich ich 7.4K Jan 13 17:18 _utils.py
-rw-rw-rw- 1 ich ich 20 Apr 7 16:05 _version.py
If I run `umask 007` before, I get the same result with `-rw-rw----`.
from torf.
rndusr
commented on September 15, 2024
I'm closing this as it doesn't seem to concern torf.
from torf.
doronbehar
commented on September 15, 2024
Sorry for the delayed response. Well first of all, as for your last comment I'm talking about the egg-info directory, not the main directory where all the .py files are located.
Besides, I've investigated the subject a little further and I've learned that the setup.py script copies the contents of a directory called torf_cli.egg-info residing in the source directory, probably created during the build process. Since the files in this directory have -rw------ permissions, no matter what the umask is. Therefor, copying these files as they are to the appropriate location specified with --root when running python setup.py makes them unreadable by non-root users, without umask having any influence.
According to this comment: PyTables/PyTables#488 (comment) perhaps you just need to upload a new version and it will be fixed.
from torf.
rndusr
commented on September 15, 2024
Thanks for researching. But I still don't see how this can be fixed in torf.
I'm talking about the egg-info directory, not the main directory where all the
`.py` files are located.
The files in `usr/local/lib/python3.6/dist-packages/torf-1.3.egg-info/` are also
affected by `umask`. At least for me.
The pkgbuild for another project of mine seems to work fine, and the relevant
parts of `setup.py` are pretty much identical.
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=stig
from torf.
doronbehar
commented on September 15, 2024
Yea, I use the AUR package stig myself as well. I wonder why this is happening, we'll see if it will appear on your next release. In the meanwhile I added chmod -R a+rX ${pkgdir} on python-torf's PKGBUILD.
from torf.
rndusr
commented on September 15, 2024
Can you reproduce this issue with stig or does it only happen in torf?
In your earlier comment you said umask is ignored for `torf_cli.egg-info` (but
not the rest of the files?). I can't reproduce that. Here's what I'm running:
$ rm -rf build/ test/ torf.egg-info
$ umask $umask
$ python3 setup.py build
$ python3 setup.py install --root="test" --optimize=1 --skip-build
$ ls -la test/usr/local/lib/python3.6/dist-packages/torf-1.3.egg-info/
As expected, if `$umask` is set to `022`, all files in the egg-info (and
everywhere else inside `./test`) are `-rw-r--r--`, with `077` it's `-rw-------`
and so on.
Can you share your exact commands?
from torf.
doronbehar
commented on September 15, 2024
Well first of all the same issue happened to me with torf-cli which this package is it's dependency. Perhaps the difference between my setup and yours is that I use as the source a tar file from https://files.pythonhosted.org/packages/source/. Source tarballs from there include from some reason the torf-1.3.egg-info directory which has the bad permissions.
I've ran the same commands with the tar file from the GitHub release and it works like a charm, without touching umask. Thanks for helping me debug this! I'll update the PKGBUILDs of your AUR packages accordingly.
from torf.
rndusr
commented on September 15, 2024
Aha! The stig pkgbuild uses the tar file from github, not from pypi. That's the
difference! The git repo doesn't track the egg-info dir, so it's created with
`python setup.py build`.
from torf.
Related Issues (20)
- v2 Torrent - Invalid metainfo: Missing 'pieces' in ['info'] HOT 1
- A question about source flag. HOT 1
- Is it possible to use single file with multi-file type directory struture? HOT 4
- Missing __enter and __exit method HOT 8
- How can I make it not create a directory HOT 1
- Is it possible to add a file with a different filename inside the torrent? HOT 4
- Too many open files HOT 5
- Piece size not power of two HOT 5
- [Feature request]load torrent file from bytes object. HOT 1
- infohash got changed after load, without any modification HOT 1
- Add link to torf-gui in readme HOT 5
- Allow setting 32MB piece size HOT 9
- `collections.abc.ByteString` is deprecated in Python 3.12 and will be removed in Python 3.14 HOT 1
- License HOT 4
- Create single file torrent from a stream HOT 5
- Allow creating 64 MB piece size HOT 2
- Subfolders HOT 2
- torf should prefer .utf-8 keys when they exist HOT 1
- Drop non critical metainfo instead of erroring? HOT 2
- Exclude tests directory HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from torf.