Comments (5)
Given there's already a reverse index available in uniques, I suggest to just keep using the upstream's. Very clever design: there's no Vec<>
, and therefore the performance problem was walked around.
from rmrk-substrate.
Currently NftsByOwner
is a StorageMap
with a key of AccountId
mapped to Vec<CollectionId, NftId>
. We could use a StorageNMap
similar to how uniques pallet handles their assets owned by an account:
Account
#[pallet::storage]
/// The assets held by any given account; set out this way so that assets owned by a single
/// account can be enumerated.
pub(super) type Account<T: Config<I>, I: 'static = ()> = StorageNMap<
_,
(
NMapKey<Blake2_128Concat, T::AccountId>, // owner
NMapKey<Blake2_128Concat, T::ClassId>,
NMapKey<Blake2_128Concat, T::InstanceId>,
),
(),
OptionQuery,
>;
remove
& insert
from the StorageNMap
Account::<T, I>::remove((&details.owner, &class, &instance));
Account::<T, I>::insert((&dest, &class, &instance), ());
owned
/// Returns an iterator of the asset instances of all classes owned by `who`.
///
/// NOTE: iterating this list invokes a storage read per item.
fn owned(who: &T::AccountId) -> Box<dyn Iterator<Item = (Self::ClassId, Self::InstanceId)>> {
Box::new(Account::<T, I>::iter_key_prefix((who,)))
}
owned_in_class
/// Returns an iterator of the asset instances of `class` owned by `who`.
///
/// NOTE: iterating this list invokes a storage read per item.
fn owned_in_class(
class: &Self::ClassId,
who: &T::AccountId,
) -> Box<dyn Iterator<Item = Self::InstanceId>> {
Box::new(Account::<T, I>::iter_key_prefix((who, class)))
}
from rmrk-substrate.
@h4x3rotab what is this reverse indexing available in uniques?
from rmrk-substrate.
@h4x3rotab what is this reverse indexing available in uniques?
This one. You can go through all the NFTs root-owned by its owner:
from rmrk-substrate.
NFtsByOwner removed in #91
from rmrk-substrate.
Related Issues (20)
- Add a restriction handler in function transfer HOT 1
- docker_run.sh not working: missing .local HOT 2
- Benchmarking: update all benchmark tests for functions using budget HOT 2
- Benchmarking: rmrk-equip pallet HOT 2
- Benchmarking: rmrk-market HOT 2
- Rmrk-Market pallet doesn't compile with `runtime-benchmark` feature HOT 8
- Build error: in Phantom_type FieldsBuilder after scale-info 2.3 update
- Allow to configure who can mint nft HOT 6
- A need to retrieve all NFTs under a certain address through one query HOT 3
- Burn NFTs causes panic HOT 3
- Have a way to bulk remove properties
- Set and Clear Collection Metadata HOT 3
- Rename Base to Catalog
- Remove Locks when selling or unlisting an NFT HOT 2
- Add a Constant Marketplace Fee Trait For Downstream
- Adding Metadata to Base HOT 5
- Add migrations code for storage changes
- Yarn Test Errors HOT 3
- Error compiling HOT 2
- Prevent Market Offer Storage Bloat
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rmrk-substrate.