Not all PDFs are actually downloaded about libation HOT 12 CLOSED

Sorry about this. Do you still have the older log from when the pdfs were downloaded? If so, can you also attach them to this bug? I'm curious to know if they could shed some light.

from libation.

No, I don't have the old logs, but I can reproduce the behavior.

When I first downloaded the whole library I run into issues due to filenames being too long. Therefore I changed the filename pattern in the settings and re-downloaded/liberated all the audiobooks. And it looks like the PDFs were not downloaded after the first time. The two audiobooks that have the PDFs were added later, so there was no re-downloading.

Steps to reproduce:

1. search for the book
2. click the "Set the Downloaded status manually..." menu item under "Visible books"
3. change it to "Not Downloaded" and save it
4. the semaphore lights next to the book will change to red
5. the menu items under "Liberate" show that 1 audiobook needs liberation, but all PDFs were downloaded

You can see this behavior in the logs I already attached.

It looks like only the "Not Downloaded" status applies only to the audio file, not to the PDF, so the application won't try to download the PDF ever again.

from libation.

@wrampy What's the filesystem of the disk where you're saving your books?

from libation.

@Mbucari ext4

from libation.

@wrampy Regarding PDF download status, there is no way to batch change PDF download statuses. However, you may change each book's PDF status manually by clicking on the book tags button in the main grid like so:

from libation.

Great, now it works. This is more of a UI/UX issue, as a user who opens this application 1-2x a month I don't know about all these hidden features. So far I did everything from the main menu and never opened this dialog of an individual book. I would recommend to extend the batch download status change functionality for PDFs (or at least put a hint there that those changes won't apply to PDFs).

And the logs Log202212.log

from libation.

I think at one point libation did have an option to set PDF statuses on all visible books, and I'm not sure what happened to it.

File names longer than Max path should be truncated, so books failing to download because of file name length is a Libation bug. I'll look into it more tomorrow.

from libation.

This was one of the books that had issues because of the long filenames:
Author: "Dr. Aziz Gazipura PsyD"
Title: "Not Nice"
Subtitle: "Stop People Pleasing, Staying Silent, & Feeling Guilty... And Start Speaking up, Saying No, Asking Boldly, and Unapologetically Being Yourself"

It has a ridiculously long subtitle. Totally 23 + 8 + 143 = 174 characters plus a few hyphens and colons in the m4b filename. Libation was able to download it to "/tmp", but when copying to its final location it quickly run out of the 255 bytes/characters (as the folder name becomes very long too) enforced by the filesystem (encrypted ext4).

from libation.

@wrampy

This is more of a UI/UX issue, as a user who opens this application 1-2x a month I don't know about all these hidden features.

Yes and no. You're absolutely right that you shouldn't need to know all the nooks and crannies in order to get this to work. The part that isn't UI is: these were marked as 'pdf downloaded' when the file wasn't actually downloaded -- that sounds like a deeper bug than UI. Which ties into what Mbucari said "File names longer than Max path should be truncated, so books failing to download because of file name length is a Libation bug"

recommend to extend the batch download status change functionality for PDFs

Agreed. I always kinda wondered if I should do this then I forgot about it. Guess I should have. Oops

@Mbucari

ext4

Does your long file name support look for max length through environmental stuff? Or do we make assumptions based on windows?

I think at one point libation did have an option to set PDF statuses on all visible books, and I'm not sure what happened to it

I don't believe so. This doesn't sound like something we would have removed.

File names longer than Max path should be truncated, so books failing to download because of file name length is a Libation bug. I'll look into it more tomorrow.

This was my thought also. Lemme know what you find

from libation.

batch download status change functionality for PDFs

Done. This feature will be included in the next version

from libation.

Unix file path issue will be included in the next version. Another thanks to @Mbucari for debugging this clusterf**k

from libation.

Included in latest: v8.8.1

from libation.