Git Product home page Git Product logo

Comments (39)

rmcrackan avatar rmcrackan commented on September 15, 2024 2

Good reminder: that's the other thing. We likely don't want to release v9 until the new year -- just as true today as it was 5 years ago

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024 1

Ok you docker weirdos :) it's showing up there now too

rmcrackan/libation

latest (and only) is 8.7.0

from libation.

Mbucari avatar Mbucari commented on September 15, 2024

@rmcrackan Nothing more from me in the near future. I'm feeling really good about the recent changes and chardonnay refactoring.

FYI, I'm out of town until Wednesday the 28th.

from libation.

pixil98 avatar pixil98 commented on September 15, 2024

No objections to being credited, my username is on Reddit is pixil. Good call on waiting until the new year. It might be worth cutting a tag now just to make sure the pipelines work correctly and it publishes to docker hub. I spent all my vacation already so I'll be around if it needs any fixes before the big release.

from libation.

wtanksleyjr avatar wtanksleyjr commented on September 15, 2024

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024

I've initiated v8.7. I expect it live within the hour

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024

@pixil98

  • I pushed the new v8.7.0 tag
  • Some actions occurred successfully incl. building artifacts
  • The releases page does not have a new draft
  • My docker repo is empty

from libation.

pixil98 avatar pixil98 commented on September 15, 2024

For some reason the workflow didn't trigger on the tag being created. Under actions there is nothing listed for the release workflow, just validate. I just tried testing it on my identical forked repo and it worked fine. How are you creating and pushing the tag?

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024
git tag v8.7.0
git push --tags

from libation.

Mbucari avatar Mbucari commented on September 15, 2024

I just tested these workflows on my repo. I created a new release with a new tag at the same time, and all of the workflows triggered as expected.

https://github.com/Mbucari/Libation/actions/runs/3745722351

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024

What was your method for creating a new release and new tag? I had pushed my code. Then separately created and pushed the tag

from libation.

Mbucari avatar Mbucari commented on September 15, 2024

I just used GitHub's web GUI. Draft a new release > choose a tag.

Then I add a new tag, and GitHub creates it when I publish the release.

from libation.

pixil98 avatar pixil98 commented on September 15, 2024

Can you try deleting the tag and recreating it or creating a new tag? I don’t see a problem with how you created the tag. I generally create the tag and push it specifically, git push origin v8.7.0

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024

Weird. git push origin v8.7.0 worked. This is how people become superstitious!

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024

@pixil98 , @Mbucari I don't remember where one of you said "When you announce v9.0 on reddit, can you add a request for help creating a .deb linux package?"

It looks like a script will be available even sooner -- #390 (comment)

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024

All known bugs are patched. I believe these are the last items before a v9 release:

@pixil98

  • Can you work your devops magic with this script and make life easier for our Linux friends?
  • All unit tests should be fixed for linux. Am I correct that they are included in the CI pipeline? And if not, is it difficult to add?

@Mbucari

  • #324 isn't a blocker so I'm fine publishing without it. There's no rush on it
  • You have a to-do list in #339 which looks stale. Is anything still needed from there?

from libation.

pixil98 avatar pixil98 commented on September 15, 2024

I can take a look at the script this weekend. It should be doable. All of the unit tests are running, on windows and linux, for each push to main and each pull request to main.

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024

@pixil98 Thanks. I was hoping to release v9 by now but my family's health imploded. Publishing is easy. If anything goes awry though, I have neither the time nor mental capacity to debug it. Hopefully normalcy will return soon.

from libation.

CharlieRussel avatar CharlieRussel commented on September 15, 2024

Seriously @rmcrackan, family is way more important than a software program. Take care and we’ll wait.

from libation.

Mbucari avatar Mbucari commented on September 15, 2024

@rmcrackan I'm sorry about your family situation, but I am glad v9 got delayed. It's nice to have something new and shiny to go along with a major version release, and I think the user ratings fit that bill nicely.

Hope everyone gets better soon!

from libation.

pixil98 avatar pixil98 commented on September 15, 2024

@rmcrackan Sorry to hear, I hope everyone is getting better. I ended up not having time last weekend to add the deb file generation. We'll still be here when things settle down and you have time and the capacity to work on it.

from libation.

wtanksleyjr avatar wtanksleyjr commented on September 15, 2024

from libation.

pixil98 avatar pixil98 commented on September 15, 2024

@wtanksleyjr oops, that not great. Can you submit an issue and I'll take care of it next chance I get?

from libation.

wtanksleyjr avatar wtanksleyjr commented on September 15, 2024

Actually, just found that was due to a mistake I'd made -- I didn't hand-create the folder, so Docker made it "for" me but with wrong permissions. Even with that fixed, though, it still won't run ... I'll submit a report, but it's almost certainly just me doing something wrong.

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024

@pixil98 @Mbucari I'm recovered from covid, back in town, and ready to release. Does anything need to be updated in the documentation first? Esp regarding linux or docker?

from libation.

Mbucari avatar Mbucari commented on September 15, 2024

@rmcrackan I updated the linux install instructions.
Nothing else from me before v9

from libation.

wtanksleyjr avatar wtanksleyjr commented on September 15, 2024

from libation.

Mbucari avatar Mbucari commented on September 15, 2024

@wtanksleyjr There isn't any Docker documentation. That was all done by @pixil98, and as far as I can tell, it uses default scripts from docker.

This is the action that guilds the docker image.

from libation.

wtanksleyjr avatar wtanksleyjr commented on September 15, 2024

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024

v9 is announced. Let the bug reports begin lol

from libation.

wtanksleyjr avatar wtanksleyjr commented on September 15, 2024

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024

@wtanksleyjr w00h00 -- thanks for that confirmation

from libation.

jhofker avatar jhofker commented on September 15, 2024

Working great on Docker here. Most difficult part was running it initially somewhere else to get the config and DB spun up. Thanks folks!

from libation.

wtanksleyjr avatar wtanksleyjr commented on September 15, 2024

from libation.

pixil98 avatar pixil98 commented on September 15, 2024

I'll write up a readme for it. It should be as simple as invoking it with:

sudo docker run -d \
  -v <path to your existing config directroy>:/config \
  --name libation \
  --restart=always \
  rmcrackan/libation

Disclaimer: I haven't actually tried running the above command.

from libation.

wtanksleyjr avatar wtanksleyjr commented on September 15, 2024

from libation.

jhofker avatar jhofker commented on September 15, 2024

I use docker compose, but it should be the same as just doing a docker run

libation:
    image: rmcrackan/libation
    container_name: libation
    volumes:
      - /local/path/for/libation/config:/config
      - /local/path/for/audio/books:/data
      - /tmp/libation:/tmp
    restart: unless-stopped

docker compose up -d

Before doing that, I ran Libation on my Windows machine to set up my account. Then copied over AccountSettings.json, LibationContext.db, and Settings.json to /local/path/for/libation/config (any path on the host machine where you store config-like stuff for your running containers). I also went through Settings.json and made the following adjustments:

  "Books": "/data",
  "InProgress": "/tmp",

I had also updated Serilog.WriteTo.Args.path to /var/logs/libation.log or something like that, but it appears that change was overwritten so it may not matter.

from libation.

rmcrackan avatar rmcrackan commented on September 15, 2024

Thanks all. I like where this docker conversation is going. Looking forward to a readme by one of you folks who clearly know docker better than me.

Docker isn't a high-demand feature. For those power users who like it though, it'll be a really valuable addition. Much like having created the CLI

from libation.

pixil98 avatar pixil98 commented on September 15, 2024

@wtanksleyjr I've added a docker.md file to the Documentation folder. I tested it out and was able to configure the latest docker image from scratch using those instructions. If you can reproduce the error you were seeing following those instructions, please write up a new issue for it and we can take a look at it.

from libation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.