Comments (9)
@rkit seems to work here,
edit: seems to get callstack error though, investigating.. get change events in loop when I try to load the values (I use https://github.com/davidkpiano/react-redux-form )
edit2: seemed to be the regular dropdown in same form as my multiselect which went on a loop when new props triggered change event. I changed dropdown to using onSelect and multiselect to use onChange which seems to work. The const handlerChanged = e => prevProps[e[1]] !== props[e[1]];
check was always true for the dropdown when using onChange
unrelated note: onUnSelect seems to trigger react unknown prop warning
from react-select2-wrapper.
- I think no.
Triggered whenever an option is selected or removed.
https://select2.github.io/options.html#events
- I will fix it soon
from react-select2-wrapper.
Please, try a new pre-release 1.0.4-beta1
from react-select2-wrapper.
Thanks Igor, I will test and update.
from react-select2-wrapper.
Hi Igor, Thanks the change works for my use case. Just a comment though. Should not it be 'prevProps' that are passed to this.detachEventHandlers() in updSelect2(). With the existing code you now cannot detach the handlers by simply not setting the corresponding props (onChange, onSelect ..)
Also on #1 from the issue,
I understand the trigger('change') call in updateValue() is needed for the select2 UI to update but this would also call the onChange() callback parent react component passes which seems unnecessary. We could add this check See master...vivekmoosani:master
from react-select2-wrapper.
Should not it be 'prevProps' that are passed to this.detachEventHandlers() in updSelect2().
Oh, yes, you're right, but you mean nextProps
instead of prevProps
?
We should detach the previous events.
Is it possible to not trigger the props.onChange() when Select2 is rendered the very first time or when props.value() is explicitly changed
… but this would also call the onChange() callback parent react component passes which seems unnecessary. We could add this check See
Yes, now I understand. I agree this needs to be fixed.
from react-select2-wrapper.
Should not it be 'prevProps' that are passed to this.detachEventHandlers() in updSelect2().
Oh, yes, you're right, but you mean nextProps instead of prevProps ?We should detach the previous events.
I meant prevProps. Say for the first render you passed
<Select2 onChange={change1} onSelect={select1} />
but then then you update props so that you only pass onChange
<Select2 onChange={change2} />
updSelect2(props) - if you do this.detachEventHandlers(props);
where props are the nextProps from componentWillReceiveProps() it would detach change1
but not select1 as props.onSelect is undefined. So we should do this.detachEventHandlers(prevProps)
from react-select2-wrapper.
Yes, I meant the same. Should be prevProps
.
We should detach the previous events.
I will fix it soon. Thanks for the report.
from react-select2-wrapper.
Please, try a new pre-release 1.0.4-beta2
from react-select2-wrapper.
Related Issues (20)
- Warning: findDOMNode is deprecated in StrictMode
- Cannot read property 'oneOfType' of undefined HOT 1
- react-select2-wrapper not working in modal bootstrap 4
- Support React V18.1.0 HOT 2
- Support React 15.5 +
- Uncaught TypeError: $element.data is not a function HOT 2
- "dropdownParent" not working properly HOT 1
- How to use .map array on data.
- Search not working HOT 1
- TypeError: this.el.select2 is not a function HOT 9
- Warning: Use the `defaultValue` or `value` props on <select> instead of setting `selected` on <option> HOT 2
- Missing style while using react Loadable
- Testing: Unable to update value in jest/enzyme tests
- Changing data doesn't cause select2 to update
- Uncaught TypeError: Cannot read property 'oneOfType' of undefined
- react-select2-wrapper is using a deprecated lifecycle hook
- Cannot resolve Jquery HOT 2
- I want to update react states, after getting data from Ajax response, but it is not working.
- There is no option to get an option by default selected and display on placeholder HOT 1
- Add typescript support
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-select2-wrapper.