Git Product home page Git Product logo

Comments (6)

rkalis avatar rkalis commented on May 19, 2024 2

@johnnyshankman I just pushed version 0.5.15 which should now display the "main" contract on top (as I described in the comment above). Thanks for the suggestion. I'll leave this issue open since the rest of the file ordering is still not the way I would prefer.

from truffle-plugin-verify.

johnnyshankman avatar johnnyshankman commented on May 19, 2024 1

Bump!

I'll add that while general ordering is great, I only need to be able to control which contract goes first.

A very common use case is one main contract with ASCII art at the top which imports a multitude of openzeppelin libraries. As long as that one contract is hoisted the top, I'm not particular about the order of the rest and the current ordering is completely fine. Essentially being able to define a root .sol/artifact that goes first.

from truffle-plugin-verify.

rkalis avatar rkalis commented on May 19, 2024 1

That's a very good point you raised there @johnnyshankman. Making sure this "root" contract is on top should be much easier than figuring out the complete path, so that is something I can add. It makes sense to me that the "root" contract is the one that is being verified. e.g. truffle run verify MetaCoin means that MetaCoin will be on top. Can you think of any cases where you wouldn't want that contract to be on top?

from truffle-plugin-verify.

johnnyshankman avatar johnnyshankman commented on May 19, 2024

@rkalis Wonderful!

from truffle-plugin-verify.

rkalis avatar rkalis commented on May 19, 2024

Since Truffle is being sunset, I don't plan to add new features, so I'm closing this issue. The "main contract on top" has been good enough for the past years any way.

from truffle-plugin-verify.

johnnyshankman avatar johnnyshankman commented on May 19, 2024

Fair nuff!

from truffle-plugin-verify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.